Page MenuHomeFreeBSD

fix "set but not used" in the tws driver
ClosedPublic

Authored by rew on Jan 7 2022, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 4:42 AM
Unknown Object (File)
Jan 12 2024, 7:42 AM
Unknown Object (File)
Dec 23 2023, 1:29 AM
Unknown Object (File)
Oct 8 2023, 5:49 AM
Unknown Object (File)
Sep 10 2023, 7:56 PM
Unknown Object (File)
Jul 4 2023, 7:38 AM
Unknown Object (File)
Jul 4 2023, 7:34 AM
Unknown Object (File)
Jul 1 2023, 4:04 PM
Subscribers

Details

Summary

With __diagused, these warnings were still emitted since INVARIANTS is
defined but TWS_DEBUG is not.

Not sure if it's better to go with __tws_debug or something like:

#ifdef TWS_DEBUG
        u_int32_t reg;
#endif

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43772
Build 40660: arc lint + arc unit

Event Timeline

rew requested review of this revision.Jan 7 2022, 7:34 PM

__tws_debug is a little shorter, but it's also a bit odd... Since you already have the right place to drop it into tws_services.h, thats likely pushes things in favor of that instead of #ifdef TWS_DEBUG or similar.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2022, 11:32 PM
This revision was automatically updated to reflect the committed changes.