loader: tftp: Copy the first block into the cache
ClosedPublic
Actions

Authored by manu on Dec 30 2021, 8:48 AM.

Details

Reviewers

mmel
tsoome

Group Reviewers

Loader

Commits

rGd37a33f52c36: loader: tftp: Copy the first block into the cache
rGdfc9c1d4937d: loader: tftp: Copy the first block into the cache

Summary

tftp_open reads the first block so copy it in the cached data.
If we have more than one block (i.e. we called tftp_read before
tftp_preload) simply just reset the transfer.

Reported by: mmel
MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43646
Build 40534: arc lint + arc unit

Event Timeline

manu created this revision.Dec 30 2021, 8:48 AM

Herald added subscribers: Contributor Reviews (src), dab, imp. · View Herald TranscriptDec 30 2021, 8:48 AM

manu requested review of this revision.Dec 30 2021, 8:48 AM

Harbormaster completed remote builds in B43646: Diff 100749.Dec 30 2021, 8:49 AM

manu added reviewers: mmel, Loader.Dec 30 2021, 8:49 AM

Tried and tested - it fixes my previous problem, thanks.

This revision is now accepted and ready to land.Dec 30 2021, 11:07 AM

tsoome accepted this revision.Dec 30 2021, 11:07 AM

Closed by commit rGdfc9c1d4937d: loader: tftp: Copy the first block into the cache (authored by manu). · Explain WhyDec 30 2021, 3:31 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGdfc9c1d4937d: loader: tftp: Copy the first block into the cache.

manu added a commit: rGd37a33f52c36: loader: tftp: Copy the first block into the cache.Jan 13 2022, 9:49 AM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

tftp.c

7 lines

Diff 100749

View Options

loader: tftp: Copy the first block into the cacheClosedPublicActions