xen/intr: combine xen_intr_bind_isrc() error cases
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Dec 23 2021, 6:22 AM.

Details

Reviewers

royger
mhorne

Summary

The error cases in xen_intr_bind_isrc() fall into two categories, those
which call xen_intr_release_isrc() and those which do not. The former
are early, caused by basic setup failure. The latter cases are closer
to final setup.

Since the error paths are likely to get more complex in the future,
combine them together as an initial step.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43552
Build 40440: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Dec 23 2021, 6:22 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2021, 6:22 AM

ehem_freebsd_m5p.com requested review of this revision.Dec 23 2021, 6:22 AM

Harbormaster completed remote builds in B43552: Diff 100487.Dec 23 2021, 6:22 AM

ehem_freebsd_m5p.com added a parent revision: D33622: xen/intr: move handler removal to isrc release.Dec 23 2021, 6:25 AM

ehem_freebsd_m5p.com added a child revision: D33624: xen/intr: add channel closing in case of early setup failure.

ehem_freebsd_m5p.com mentioned this in D31355: xen/intr: hand off closing of ports sooner.Dec 23 2021, 6:30 AM

mhorne mentioned this in D31188: xen/intr: move isrc allocation out of xen_intr_bind_isrc().Dec 27 2021, 3:59 PM

Appears this ended up disappearing. Perhaps keep portions got merged into D33624.

ehem_freebsd_m5p.com removed a parent revision: D33622: xen/intr: move handler removal to isrc release.Jun 29 2022, 12:00 AM

ehem_freebsd_m5p.com removed a child revision: D33624: xen/intr: add channel closing in case of early setup failure.Jun 29 2022, 12:04 AM

Revision Contents
Changeset List

Path

Size

sys/

xen/

xen_intr.c

30 lines

Diff 100487

View Options

xen/intr: combine xen_intr_bind_isrc() error casesAbandonedPublicActions