Diffusion FreeBSD src repository c606ab59e7f9

vm_extern: use standard address checkers everywhere
c606ab59e7f9
Actions

Description

vm_extern: use standard address checkers everywhere

Define simple functions for alignment and boundary checks and use them
everywhere instead of having slightly different implementations
scattered about. Define them in vm_extern.h and use them where
possible where vm_extern.h is included.

Reviewed by: kib, markj
Differential Revision: https://reviews.freebsd.org/D33685

Details

Provenance

dougm

Authored on Dec 31 2021, 4:09 AM

Reviewer

kib

Differential Revision

D33685: Define and use standard functions for alignment checking

Parents

rGc09981f1422e: mips: Remove sys/mips

Branches

Unknown

Tags

Unknown

Event Timeline

dougm committed rGc606ab59e7f9: vm_extern: use standard address checkers everywhere (authored by dougm).Dec 31 2021, 4:09 AM

dougm added an edge: D33685: Define and use standard functions for alignment checking.Dec 31 2021, 4:14 AM

dougm mentioned this in rG01e115ab83a4: vm_phys: #include vm_extern.Dec 31 2021, 5:35 AM

dougm mentioned this in rGf76916c0956d: vm_reserv: #include vm_extern.h explicitly, for arm..Dec 31 2021, 6:42 AM

dougm mentioned this in rGcfb2aa3f530f: iommu_gas: Rename a function missed earlier.Dec 31 2021, 7:51 AM

dougm mentioned this in rGb49612688608: riscv-busdma: Balance parens..Dec 31 2021, 8:02 AM

dougm mentioned this in rGb7810e05ff1d: x86-busdma - Add missing paren.Dec 31 2021, 8:35 AM

dougm mentioned this in D33715: budsma: fix boundary alignment test.Jan 1 2022, 11:48 PM

Now that there is only one set of vm_addr check functions, how about adding a parameter check for INVARIANTS builds?
Calling with parameters that are not a power of 2 will call spurious results, which might cause hard to debug issues ...

/sys/vm/vm_extern.h

136

Add a test macro:

#define IS_POW2(n) (((n) & (-n)) == (n))

142

#ifdef INVARIANTS
    if (!IS_POW2(alignment))
        panic("vm_addr_align_ok: alignment is not a power of 2: 0x%lx", alignment);
#endif

152

#ifdef INVARIANTS
    if (!IS_POW2(boundary))
        panic("vm_addr_bound_ok: boundary is not a power of 2: 0x%lx", boundary);
#endif

dougm mentioned this in rGf1e7a532d1ee: busdma: _bus_dmamap_addseg repaired.Jan 2 2022, 6:43 PM

jhibbits mentioned this in rG3a9688f8bc48: busdma: Fix powerpc DMA alignment check.Jan 4 2022, 3:25 PM

dougm mentioned this in rGc5a5a9dbcf38: vm_extern: use standard address checkers everywhere.Jul 12 2022, 5:32 PM

dougm mentioned this in rG87e6f3d27eba: vm_phys: #include vm_extern.

dougm mentioned this in rG6f387a563206: vm_reserv: #include vm_extern.h explicitly, for arm..

dougm mentioned this in rG0cbb744f96db: iommu_gas: Rename a function missed earlier.

dougm mentioned this in rG3af858bd8f78: riscv-busdma: Balance parens..

dougm mentioned this in rGab0f2ae2eeda: x86-busdma - Add missing paren.

dougm mentioned this in rG01f79c9da806: busdma: _bus_dmamap_addseg repaired.

alfredo mentioned this in rG603bbd771f0c: busdma: Fix powerpc DMA alignment check.Oct 3 2022, 10:47 PM

Changes (18)

Path

Size

sys/

arm/

busdma_machdep.c

arm64/

busdma_bounce.c

dev/

iommu/

	mips/	mips/
	powerpc/	powerpc/

powerpc/

riscv/

vm/

x86/

rGc606ab59e7f9

View Options

sys/arm/arm/busdma_machdep.c

View Options

sys/arm64/arm64/busdma_bounce.c

View Options

sys/dev/iommu/busdma_iommu.c

View Options

sys/dev/iommu/iommu.h

View Options

sys/dev/iommu/iommu_gas.c

View Options

sys/mips/mips/busdma_machdep.c

View Options

sys/powerpc/powerpc/busdma_machdep.c

View Options

sys/riscv/riscv/busdma_bounce.c

View Options

sys/riscv/riscv/busdma_machdep.c

View Options

sys/vm/vm_extern.h

View Options

sys/vm/vm_map.c

View Options

sys/vm/vm_page.c

View Options

sys/vm/vm_phys.c

View Options

sys/vm/vm_reserv.c

View Options

sys/x86/x86/busdma_bounce.c

View Options

sys/x86/x86/busdma_machdep.c

vm_extern: use standard address checkers everywherec606ab59e7f9Actions

Description

Details

Event Timeline

Changes (18)

rGc606ab59e7f9

sys/arm/arm/busdma_machdep.c

sys/arm64/arm64/busdma_bounce.c

sys/dev/iommu/busdma_iommu.c

sys/dev/iommu/iommu.h

sys/dev/iommu/iommu_gas.c

sys/mips/mips/busdma_machdep.c

sys/powerpc/powerpc/busdma_machdep.c

sys/riscv/riscv/busdma_bounce.c

sys/riscv/riscv/busdma_machdep.c

sys/vm/vm_extern.h

sys/vm/vm_map.c

sys/vm/vm_page.c

sys/vm/vm_phys.c

sys/vm/vm_reserv.c

sys/x86/x86/busdma_bounce.c

sys/x86/x86/busdma_machdep.c

vm_extern: use standard address checkers everywhere
c606ab59e7f9
Actions