Page MenuHomeFreeBSD
Differential D991

Fix linking binaries with -latf
ClosedPublic
Actions

Authored by ngie on Oct 21 2014, 8:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 30, 8:55 AM
Unknown Object (File)
Fri, Sep 25, 3:54 PM
Unknown Object (File)
Mon, Sep 21, 1:00 PM
Unknown Object (File)
Sun, Sep 20, 12:30 PM
Unknown Object (File)
Fri, Sep 18, 6:47 PM
Unknown Object (File)
Sat, Sep 12, 7:25 AM
Unknown Object (File)
Sat, Sep 12, 2:35 AM
Unknown Object (File)
Sep 11 2026, 1:14 AM
View All 99 Files
Subscribers
imp
jmmv

Details

Reviewers
bapt
jmmv
bdrewery
Summary

Fix linking binaries with -latf

Check for -static in LDFLAGS or LDFLAGS.<test>, then pass in the appropriate
dependency (LIBATF or LDATF)

This unbreaks the build with some of the NetBSD tests that need to be compiled
statically

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ngie updated this revision to Diff 2084.Oct 21 2014, 8:32 PM
ngie retitled this revision from to Fix linking binaries with -latf.
ngie updated this object.
ngie added a reviewer: bapt.
ngie added subscribers: imp, jmmv.
Herald added a reviewer: bdrewery. · View Herald TranscriptOct 21 2014, 8:32 PM
jmmv accepted this revision.Oct 22 2014, 9:53 AM
jmmv added a reviewer: jmmv.

This seems reasonable to me.

This revision is now accepted and ready to land.Oct 22 2014, 9:53 AM
imp added a comment.Oct 22 2014, 2:01 PM

looks good to me.

ngie closed this revision.Oct 22 2014, 6:11 PM

Committed as r273478 -- thank you!

Revision Contents
Changeset List

PathSize
share/
mk/
8 lines

Diff 2084

View Options

share/mk/atf.test.mk

Loading...