Page MenuHomeFreeBSD

Fix memory leaks in dhclient
ClosedPublic

Authored by trix_juniper.net on Mar 5 2017, 2:07 PM.

Details

Summary

parse.c parse_string
When parse_semi fails, free s before returning

parse.c parse_numeric_aggregate
The memory assigned to bufp is complicated, it can either be from the input parameter buf or allocated locally. Introduce a new variable lbufp to track when it is assigned locally and to free it when appropriate.

Test Plan

Run clang's static analyzer, scan-build, to find the problems, run later to show resolutions.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trix_juniper.net retitled this revision from to Fix memory leaks in dhclient.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added reviewers: stevek, brooks, jhb.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository.
jhb accepted this revision.Mar 6 2017, 5:39 PM
jhb edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2017, 5:39 PM
This revision was automatically updated to reflect the committed changes.