Fix a memory leak in ipfilter
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 3 2017, 4:57 PM.

Details

Reviewers

ngie
cy
stevek

Commits

rS314834: MFC r314627:
rS314627: Fix leak (free str before returning when ctx's calloc fails).

Summary

lib/save_v2trace.c snmpv2_parse
Free str before returning when ctx's calloc fails

Test Plan

Run clang's static analyzer, scan-build, to find the problem, then later to show resolution.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trix_juniper.net updated this revision to Diff 25937.Mar 3 2017, 4:57 PM

trix_juniper.net retitled this revision from to Fix a memory leak in ipfilter.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, cy, ngie.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2017, 4:57 PM

ngie accepted this revision.Mar 3 2017, 5:53 PM

ngie edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2017, 5:53 PM

I will commit this shortly for you.

Closed by commit rS314627: Fix leak (free str before returning when ctx's calloc fails). (authored by cy). · Explain WhyMar 3 2017, 9:32 PM

This revision was automatically updated to reflect the committed changes.

cy mentioned this in rS314627: Fix leak (free str before returning when ctx's calloc fails)..

cy mentioned this in rS314834: MFC r314627:.Mar 7 2017, 5:35 AM

Revision Contents
Changeset List

Path

Size

head/

contrib/

ipfilter/

lib/

save_v2trap.c

4 lines

Diff 25954

View Options

head/contrib/ipfilter/lib/save_v2trap.c

Fix a memory leak in ipfilterClosedPublicActions