Page MenuHomeFreeBSD

Replace deprecated git repo-config
ClosedPublic

Authored by adridg on Mar 2 2017, 10:53 AM.
Tags
None
Referenced Files
F84766038: D9861.id.diff
Tue, May 28, 7:46 AM
F84765056: D9861.id25877.diff
Tue, May 28, 7:19 AM
Unknown Object (File)
Sat, May 18, 5:37 PM
Unknown Object (File)
Fri, May 3, 4:33 PM
Unknown Object (File)
Apr 21 2024, 6:25 AM
Unknown Object (File)
Dec 9 2023, 1:10 AM
Unknown Object (File)
Dec 2 2023, 5:42 AM
Unknown Object (File)
Nov 18 2023, 6:53 AM
Subscribers

Details

Summary

repo-config is no longer supported by any upstream-supported
git version. Instead, use git config (which is implicitly
git config --file, corresponding to the earlier config-in-repo).

Every time you start qgit, or refresh a repo, you get a popup
saying that repo-config is not recognized. This makes qgit
annoying to use at best. Unless you have a really old git
installed, the intent of the config option is broken.

Test Plan

Builds for me (amd64, 10.3). Runs, too, without the annoying popup.
Since I don't have any repo's that actually use commitEncoding,
I don't have much to user-test with -- but given that after the
popup it was falling back to utf-8 anyway, this can't be a
regression.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg retitled this revision from to Replace deprecated git repo-config.
adridg updated this object.
adridg edited the test plan for this revision. (Show Details)
adridg added a reviewer: tcberner.

Maintainer of the port is listed as itetcu@, but that doesn't work in Phab -- adding some KDE peeps instead.

tcberner edited edge metadata.

There is also a commit for this in the 'official' github repo
https://github.com/tibirna/qgit/commit/6a4f1086114478e5f0be9929da92aad42123d988

As your patch however contains a descriptive comment, and it's not quite clear how 'official' the so called 'official' repository on github actually is, I think it's ok to just use your patch :)

This revision is now accepted and ready to land.Mar 2 2017, 12:30 PM
rakuco edited edge metadata.

lgtm. @tcberner: feel free to land this and close any PR that might exist about this (don't forget to MFH the change).

This revision was automatically updated to reflect the committed changes.