Fix locking on the vt driver's data structures.
ClosedPublic
Actions

Authored by jtl on Feb 22 2017, 12:09 AM.

Details

Reviewers

ray
emaste
ed

Commits

rS314116: Fix a panic during boot caused by inadequate locking of some vt(4) driver

Summary

vt_change_font() calls vtbuf_grow() to change some vt driver data structures. It uses TF_MUTE to prevent the console from trying to use those data structures while it changes them.

The vt driver's tc_done routine uses those data structures; however, it is currently called outside the TF_MUTE check.

Move the tc_done routine inside the locked TF_MUTE check.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl updated this revision to Diff 25500.Feb 22 2017, 12:09 AM

jtl retitled this revision from to Fix locking on the vt driver's data structures..

jtl updated this object.

jtl edited the test plan for this revision. (Show Details)

jtl added reviewers: emaste, ray.

jtl added a subscriber: ed.

Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2017, 12:09 AM

ed accepted this revision.Feb 22 2017, 6:48 AM

ed added a reviewer: ed.

This revision is now accepted and ready to land.Feb 22 2017, 6:48 AM

Looks good. Thank you, Jonathan!

Closed by commit rS314116: Fix a panic during boot caused by inadequate locking of some vt(4) driver (authored by jtl). · Explain WhyFeb 23 2017, 1:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

subr_terminal.c

8 lines

Diff 25609

View Options

head/sys/kern/subr_terminal.c

Fix locking on the vt driver's data structures.ClosedPublicActions