Page MenuHomeFreeBSD

bnxt: propagate RSS hash type to the network stack.
ClosedPublic

Authored by venkatkumar.duvvuru_broadcom.com on Feb 20 2017, 10:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 6:54 PM
Unknown Object (File)
Sat, Aug 31, 5:50 PM
Unknown Object (File)
Tue, Aug 27, 11:43 PM
Unknown Object (File)
Fri, Aug 23, 8:35 PM
Unknown Object (File)
Aug 6 2024, 1:16 AM
Unknown Object (File)
Aug 5 2024, 7:43 AM
Unknown Object (File)
Jul 28 2024, 4:28 AM
Unknown Object (File)
Jul 26 2024, 7:30 PM

Details

Summary

RSS hash type will be used to identify the CPU on to which, a receive packet will be queued.
This patch extracts the "RSS hash type" from the receive completion and sends it to the stack.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

venkatkumar.duvvuru_broadcom.com retitled this revision from to bnxt: propagate RSS hash type to the network stack..
venkatkumar.duvvuru_broadcom.com edited the test plan for this revision. (Show Details)
adrian edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2017, 12:21 AM
sbruno added a subscriber: shurd.
shurd requested changes to this revision.Feb 21 2017, 9:59 PM
shurd added a reviewer: shurd.

Minor style(9) quibble.

sys/dev/bnxt/bnxt_txrx.c
415 ↗(On Diff #25412)

Type should be on a separate line.

This revision now requires changes to proceed.Feb 21 2017, 9:59 PM

Possible optimization.

sys/dev/bnxt/bnxt.h
102 ↗(On Diff #25412)

Is this first mask really necessary? It looks like:

((rss_hash_type >> 1) & 0x1f)

Would do the same thing with fewer operations. This is in the RX fast path.

venkatkumar.duvvuru_broadcom.com edited edge metadata.

bnxt: [v2] propagate RSS hash type to the network stack.

RSS hash type will be used to identify the CPU on to which, a receive packet will be queued.
This patch extracts the "RSS hash type" from the receive completion and sends it to the stack.

v2 changes:

  1. Changed BNXT_GET_RSS_PROFILE_ID macro
  2. bnxt_set_rsstype function type is put on a separate line.
shurd edited edge metadata.

Looks good, approved.

This revision is now accepted and ready to land.Feb 22 2017, 3:52 PM
sbruno added a reviewer: sbruno.
sbruno added a subscriber: sbruno.

stlgtm

This revision was automatically updated to reflect the committed changes.