Page MenuHomeFreeBSD

bnxt: propagate RSS hash type to the network stack.
ClosedPublic

Authored by venkatkumar.duvvuru_broadcom.com on Feb 20 2017, 10:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 2:12 AM
Unknown Object (File)
Sat, Nov 9, 5:59 AM
Unknown Object (File)
Wed, Oct 30, 2:25 PM
Unknown Object (File)
Oct 24 2024, 9:44 PM
Unknown Object (File)
Sep 30 2024, 4:34 AM
Unknown Object (File)
Sep 24 2024, 4:19 AM
Unknown Object (File)
Sep 22 2024, 7:42 PM
Unknown Object (File)
Sep 19 2024, 9:21 PM

Details

Summary

RSS hash type will be used to identify the CPU on to which, a receive packet will be queued.
This patch extracts the "RSS hash type" from the receive completion and sends it to the stack.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

venkatkumar.duvvuru_broadcom.com retitled this revision from to bnxt: propagate RSS hash type to the network stack..
venkatkumar.duvvuru_broadcom.com edited the test plan for this revision. (Show Details)
adrian edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2017, 12:21 AM
sbruno added a subscriber: shurd.
shurd requested changes to this revision.Feb 21 2017, 9:59 PM
shurd added a reviewer: shurd.

Minor style(9) quibble.

sys/dev/bnxt/bnxt_txrx.c
415 ↗(On Diff #25412)

Type should be on a separate line.

This revision now requires changes to proceed.Feb 21 2017, 9:59 PM

Possible optimization.

sys/dev/bnxt/bnxt.h
102 ↗(On Diff #25412)

Is this first mask really necessary? It looks like:

((rss_hash_type >> 1) & 0x1f)

Would do the same thing with fewer operations. This is in the RX fast path.

venkatkumar.duvvuru_broadcom.com edited edge metadata.

bnxt: [v2] propagate RSS hash type to the network stack.

RSS hash type will be used to identify the CPU on to which, a receive packet will be queued.
This patch extracts the "RSS hash type" from the receive completion and sends it to the stack.

v2 changes:

  1. Changed BNXT_GET_RSS_PROFILE_ID macro
  2. bnxt_set_rsstype function type is put on a separate line.
shurd edited edge metadata.

Looks good, approved.

This revision is now accepted and ready to land.Feb 22 2017, 3:52 PM
sbruno added a reviewer: sbruno.
sbruno added a subscriber: sbruno.

stlgtm

This revision was automatically updated to reflect the committed changes.