Page MenuHomeFreeBSD
Differential D9659

Remove -flto when building genassym.o
ClosedPublic
Actions

Authored by emaste on Feb 18 2017, 4:10 AM.
Tags
None
Referenced Files
F170836459: D9659.id25342.diff
Sun, Sep 6, 10:52 PM
Unknown Object (File)
Sun, Sep 6, 9:45 PM
Unknown Object (File)
Sun, Sep 6, 1:07 PM
Unknown Object (File)
Sun, Sep 6, 4:52 AM
Unknown Object (File)
Sun, Sep 6, 2:30 AM
Unknown Object (File)
Sat, Sep 5, 10:15 PM
Unknown Object (File)
Sat, Sep 5, 7:26 PM
Unknown Object (File)
Sat, Sep 5, 7:25 PM
View All Files
Subscribers
None

Details

Reviewers
dim
davide
bdrewery
Commits
rS314054: Exclude -flto when building *genassym.o
Summary

The build process generates *assym.h using nm from *genassym.o (which is in turn created from *genassym.c).

When compiling with link-time optimization (LTO) using -flto, .o files are LLVM bitcode, not ELF objects. This is not acceptable in the genassym process so remove -flto from those ${CC} invocations.

Submitted by: George Rimar

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 25342.Feb 18 2017, 4:10 AM
emaste retitled this revision from to Remove -flto when building genassym.o.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: dim, bdrewery, davide.
dim accepted this revision.Feb 18 2017, 9:14 PM
dim edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 18 2017, 9:14 PM
Closed by commit rS314054: Exclude -flto when building *genassym.o (authored by emaste). · Explain WhyFeb 21 2017, 6:59 PM
This revision was automatically updated to reflect the committed changes.
imp mentioned this in rGc6ae97c44d4d: sys: ${CFLAGS:N-flto} -> ${CFLAGS:N-flto*}.Dec 26 2023, 11:57 PM

Revision Contents
Changeset List

PathSize
head/
sys/
conf/
4 lines
4 lines
2 lines
2 lines
modules/
linux/
2 lines
linux64/
2 lines
svr4/
2 lines
vmm/
4 lines

Diff 25491

View Options

head/sys/conf/files.amd64

Loading...
View Options

head/sys/conf/files.i386

Loading...
View Options

head/sys/conf/kern.post.mk

Loading...
View Options

head/sys/conf/kmod.mk

Loading...
View Options

head/sys/modules/linux/Makefile

Loading...
View Options

head/sys/modules/linux64/Makefile

Loading...
View Options

head/sys/modules/svr4/Makefile

Loading...
View Options

head/sys/modules/vmm/Makefile

Loading...