More cleanups of x86_mem.c.
ClosedPublic
Actions

Authored by kib on Feb 17 2017, 9:30 PM.

Details

Reviewers

jhb
royger

Commits

rS313903: Rely on CPUID feature only to enable attaching. MTRR are architectural
rS313902: smp_rendezvous() works for UP case as well, reduce duplicated

Summary

There are really two changes, I keep it in one review to reduce bureaucracy.

Rely on CPUID feature only to enable attaching. MTRR are architectural and there is no reason to check cpu family or vendor.
Noted by: royger

smp_rendezvous() works for UP case as well, reduce duplicated code. Also fix cast.
Noted by: jhb

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib updated this revision to Diff 25334.Feb 17 2017, 9:30 PM

kib retitled this revision from to More cleanups of x86_mem.c..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added reviewers: royger, jhb.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2017, 9:30 PM

jhb accepted this revision.Feb 17 2017, 10:41 PM

jhb edited edge metadata.

This revision is now accepted and ready to land.Feb 17 2017, 10:41 PM

Closed by commit rS313902: smp_rendezvous() works for UP case as well, reduce duplicated (authored by kib). · Explain WhyFeb 17 2017, 10:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

x86/

x86_mem.c

18 lines

Diff 25338

View Options

head/sys/x86/x86/x86_mem.c

More cleanups of x86_mem.c.ClosedPublicActions