Page MenuHomeFreeBSD
Differential D9652

fix memory leak in 'finger'
ClosedPublic
Actions

Authored by trix_juniper.net on Feb 17 2017, 5:50 PM.
Tags
None
Referenced Files
F131925392: D9652.diff
Sun, Oct 12, 6:26 AM
F131880096: D9652.id29544.diff
Sat, Oct 11, 10:26 PM
F131880047: D9652.id.diff
Sat, Oct 11, 10:25 PM
F131880041: D9652.id25319.diff
Sat, Oct 11, 10:25 PM
F131831472: D9652.diff
Sat, Oct 11, 1:10 PM
Unknown Object (File)
Mon, Sep 15, 12:49 AM
Unknown Object (File)
Sep 12 2025, 4:34 AM
Unknown Object (File)
Sep 12 2025, 3:15 AM
View All 83 Files
Subscribers
imp

Details

Reviewers
stevek
ed
Commits
rS319903: The variable nargv is allocated but never freed, so free it when the it
Summary

the variable nargv is allocated but never freed, so free it when the it is no longer used

Test Plan

Run clang's scan-build before the fix to find the problem, run after to verify fixed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trix_juniper.net updated this revision to Diff 25319.Feb 17 2017, 5:50 PM
trix_juniper.net retitled this revision from to fix memory leak in 'finger'.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added reviewers: stevek, ed.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2017, 5:50 PM
ed accepted this revision.Feb 17 2017, 5:53 PM
ed edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2017, 5:53 PM
Closed by commit rS319903: The variable nargv is allocated but never freed, so free it when the it (authored by stevek). · Explain WhyJun 13 2017, 3:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
finger/
1 line

Diff 29544

View Options

head/usr.bin/finger/finger.c

Loading...