While reading code in preparation to add libxo support, fix style(9)
Sponsored by: Rubicon Communications (Netgate)
MFC after: 1 week
Details
Details
- Reviewers
allanjude ngie tuexen vangyzen loos - Commits
- rS314595: MFC r314039:
rS314039: Fix style(9)
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| usr.bin/sockstat/sockstat.c | ||
|---|---|---|
| 154 ↗ | (On Diff #25137) | style(9) was recently changed to permit the braces that were here. I personally prefer the braces, especially in cases like this, where the else has braces. |
| 393 ↗ | (On Diff #25137) | I'm not sure if style(9) covers this. I think the prevailing style would put sizeof at the beginning of the next line. Personally, I would prefer that. Ditto three times below. |
| 459 ↗ | (On Diff #25137) | I would prefer to separate the assignment and the comparison instead of wrapping the line, but this is fine. |
| 504 ↗ | (On Diff #25137) | Ditto line 459. |
| 1029 ↗ | (On Diff #25137) | I'm not sure that style(9) requires this. I personally prefer the old way. |
| usr.bin/sockstat/sockstat.c | ||
|---|---|---|
| 459 ↗ | (On Diff #25137) | I should have been more clear. I'm sorry. I meant: laddr = calloc(...);
if (laddr == NULL) { |
| usr.bin/sockstat/sockstat.c | ||
|---|---|---|
| 461 ↗ | (On Diff #25241) | err() call should point to "calloc()" here. There are other places I see the same issue. I'll submit a separate review |
Comment Actions
Approved By: allanjude
| usr.bin/sockstat/sockstat.c | ||
|---|---|---|
| 461 ↗ | (On Diff #25241) | calloc(num, size) is just a safe wrapper around malloc(num * size), so the error message is fine |