Page MenuHomeFreeBSD

Update finance/skrooge to 2.7.0
ClosedPublic

Authored by tcberner on Jan 25 2017, 8:21 PM.

Details

Summary

Update it to 2.7.0

Other stuff

  • cleanup the bits that came in from the testing repo
    • don't set an unecessary PGKNAMESUFFIX.
    • there never was a skrooge-kde4 in ports, so no need to conflict with it
Test Plan

poudriere is testing it on 103@32 and current@64 at the moment...

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner updated this revision to Diff 24442.Jan 25 2017, 8:21 PM
tcberner updated this revision to Diff 24443.
tcberner retitled this revision from to Update finance/skrooge to 2.7.0.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, rakuco, mat, fluffy, adridg.

readd dropped empty line before USES

fluffy accepted this revision.Jan 26 2017, 3:35 AM
fluffy edited edge metadata.

One small note: please keep PGKNAMESUFFIX. Keep naming in order, as other official -kf5 extras

This revision is now accepted and ready to land.Jan 26 2017, 3:35 AM

One small note: please keep PGKNAMESUFFIX. Keep naming in order, as other official -kf5 extras

There are no other -kf5 ports in the tree, and I don't see a reason why we should add unnecessary suffixes. The ports in the testing repo only carry a suffix so that we can keep both versions there.
[Also, if the pkgname is skrooge-kf5, the directory should be renamed to finance/skrooge-kf5 -- I hate inconsistency :)].

rakuco accepted this revision.Jan 26 2017, 1:37 PM
rakuco edited edge metadata.

I'm also in favor of not setting PKGNAMESUFFIX since we only have one Skrooge version in the tree (and have always had one).

This revision was automatically updated to reflect the committed changes.