PR: 193973 (+ some of my changes)
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please upload with context, e.g. git diff -U9999 or the svn command from https://wiki.freebsd.org/Phabricator
| contrib/traceroute/traceroute.c | ||
|---|---|---|
| 561 ↗ | (On Diff #24345) | Is this message correct in the current libcasper world order? Should it be an error? |
| contrib/traceroute/traceroute.c | ||
|---|---|---|
| 563 ↗ | (On Diff #24350) | Given the if block above will exit, no need for a else block here |
| 598 ↗ | (On Diff #24350) | casper cannot be null at this point given there checks above that exits |
| 1023 ↗ | (On Diff #24350) | This will always be true there is a check above for that. |
| 1858 ↗ | (On Diff #24350) | maybe if would be more readable to have a bunch of defined earlier: #if HAVE_LIBCAPSER #define tcrt_gethostbyname(domain) cpa_gethostbyname(capdns, domain) #else #define tcrt_gethostbyname(domain) cpa_gethostbyname(capdns, domain) #endif with all functions like that |
| contrib/traceroute/traceroute.c | ||
|---|---|---|
| 230 ↗ | (On Diff #24350) | we compile with -DHAVE_LIBCASPER; does this #if work? |
| 370 ↗ | (On Diff #24350) | maybe lose the extra space here, like you do with HAVE_LIBCASPER stack variables in fns? |
| 561–562 ↗ | (On Diff #24350) | errx instead of perror/exit? |
| 1034 ↗ | (On Diff #24350) | given that we already have cansandbox variable I'd prefer if we set if false if capsicum is not available, and drop the ENOSYS case |
| usr.sbin/traceroute/Makefile | ||
| 3–4 ↗ | (On Diff #24350) | it seems odd to have both of these; afaik we need only src.opts.mk? |
| contrib/traceroute/traceroute.c | ||
|---|---|---|
| 230 ↗ | (On Diff #24350) | After one more look I get this ;) |
| contrib/traceroute/traceroute.c | ||
|---|---|---|
| 565–566 ↗ | (On Diff #25369) | what about initializing these with const char *types[] = { "NAME", "ADDR" };? |