Page MenuHomeFreeBSD

devel/tortoisehg -- don't include hgext3rd
ClosedPublic

Authored by tcberner on Jan 21 2017, 7:33 AM.

Details

Summary
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PYTHON_SITELIBDIR%%/hgext3rd/__init__.py
Error: Orphaned: %%PYTHON_SITELIBDIR%%/hgext3rd/__init__.pyc
Error: Orphaned: %%PYTHON_SITELIBDIR%%/hgext3rd/__init__.%%PYTHON_PYOEXTENSION%%
Error: Orphaned: %%PYTHON_SITELIBDIR%%/hgext3rd/thg.py
Error: Orphaned: %%PYTHON_SITELIBDIR%%/hgext3rd/thg.pyc
Error: Orphaned: %%PYTHON_SITELIBDIR%%/hgext3rd/thg.%%PYTHON_PYOEXTENSION%%
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

The files are not included in the package as they are [at least the first three] are installed by devel/mercurial.
[as the latter three weren't installed either, I don't think this breaks any thing more :D]

The diff removes 'hext3rd' from setup.py, to get rid of them being staged.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner retitled this revision from to devel/tortoisehg -- don't include hgext3rd.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: rakuco, mat.

Mercurial itself only installs the __init__.py bits, so your patch prevents the actual thg.py files from being installed by any port. What Debian and Fedora do is just rm the __init__.py files and install the rest, which probably makes more sense.

tcberner edited edge metadata.

Install thg.py, and bump PORTREVISION.

This revision is now accepted and ready to land.Jan 21 2017, 11:35 AM
arrowd added a reviewer: arrowd.
This revision was automatically updated to reflect the committed changes.
head/devel/tortoisehg/Makefile
43–44

Instead of this, you could have ${RM}'ed it in post-extract:, it is a bit less magic, and it is one less thing to wonder about when I update bits of the framework :-)

I wish people would try to do simpler things instead of doing clever ones.