Page MenuHomeFreeBSD

share/examples: use mtree -W flag when installing with -DNO_ROOT
ClosedPublic

Authored by arichardson on Jan 17 2017, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 11:32 PM
Unknown Object (File)
Feb 9 2024, 5:45 PM
Unknown Object (File)
Feb 6 2024, 1:57 PM
Unknown Object (File)
Dec 29 2023, 1:17 AM
Unknown Object (File)
Dec 27 2023, 10:11 AM
Unknown Object (File)
Nov 30 2023, 12:05 PM
Unknown Object (File)
Nov 21 2023, 3:43 AM
Unknown Object (File)
Nov 6 2023, 3:24 AM
Subscribers
None

Details

Summary

The call to mtree should not be necessary as the directories should already
have been created.

This removes thousands of lines of warning output from make installworld
with -DNO_ROOT:

.: user (0, 3375, not modified: Operation not permitted)

gid (0, 3375, not modified: Operation not permitted)

share: user (0, 3375, not modified: Operation not permitted)

gid (0, 3375, not modified: Operation not permitted)

share/misc:

user (0, 3375, not modified: Operation not permitted)
gid (0, 3375, not modified: Operation not permitted)

etc...

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson retitled this revision from to share/examples: use mtree -W flag when installing with -DNO_ROOT.
arichardson updated this object.
arichardson edited the test plan for this revision. (Show Details)
arichardson added reviewers: bdrewery, gjb, brooks.

This seems pretty reasonable. I'm a little leary of not setting modes, but in practice that's probably ok for NO_ROOT installs.

I wonder if the line should be removed instead. BSD.usr.dist seems to already be handled in etc/Makefile.

The line was introduced in r100346 by ru@, and later updated (just the mechanical path update) in r314652 by ngie@.

arichardson edited the summary of this revision. (Show Details)

Removed the mtree invocation instead

This revision is now accepted and ready to land.May 22 2017, 5:21 PM
This revision was automatically updated to reflect the committed changes.