[NEW PORT] devel/sonar-ant-task: SonarQube Plugin for analysis projects with an Apache Ant

[ler]

Summary

[NEW PORT] devel/sonar-ant-task: SonarQube Plugin for analysis projects with an Apache Ant

The Ant SonarQube Task allows integration of SonarQube analysis into an Apache
Ant build script. The Ant Task is a thin wrapper around the SonarQube Runner,
which works by invoking the runner and passing to it all properties named
following a sonar.* convention. This has the downside of not being very Ant-y,
but the upside of providing instant availability of any new analysis parameter
introduced by a new version of a plugin or of SonarQube itself.

PR: 203075
Submitted by: Dušan Vejnovič (freebsd dussan.org)
Approved by: (adamw|rene) (mentor)

Test Plan

poudriere: ok (http://home.lerctr.org:8888/data/pHEADamd64-ler-checkout/2017-01-15_13h36m51s/logs/sonar-ant-task-2.5.log)
portlint -Ac: ok
borg.lerctr.org ~/FreeBSD/ports/devel/sonar-ant-task $ portlint -Ac
WARN: /home/ler/FreeBSD/ports/devel/sonar-ant-task/pkg-descr: includes lines that exceed 80 characters.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 2 warnings found.

[rene]

• SQ is defined the wrongly, it should be SQ= ${LOCALBASE}/sonarqube/bin/freebsd (PREFIX is where *this* port installs its files, LOCALBASE is where other ports install their files)

• Would it be better to install the jar file into ${STAGEDIR}${SHAREDIR}${PORTNAME}/${PORTNAME}${EXTRACT_SUFX} ? But perhaps that's a matter of taste.

[ler]

Rene's comments addressed.

[rene]

Well if you are changing the INSTALL_DATA line, you should also change the two surrounding lines and make sure the plug-in still works.

[ler]

address portlint/poudriere/pkg-message issues.

new poudriere:
http://home.lerctr.org:8888/data/pHEADamd64-ler-checkout/2017-01-15_16h13m25s/logs/sonar-ant-task-2.5.log

[adamw]

Makefile

37 ↗

(On Diff #24042)

I don't really like this depending on a .sample file. That seems pretty fragile. Just depend on the port itself.

SQ_RUN_DEPENDS=    sonarqube>=0:devel/sonarqube

43 ↗

(On Diff #24042)

Wow, this is not right. ${LOCALBASE} is where stuff that already exists is. ${PREFIX} is where THIS port installs to. They can never be exchanged.

@${MKDIR} ${STAGEDIR}${DATADIR}

[adamw]

Makefile

43 ↗

(On Diff #24042)

Also, does it really have to be writeable? Normally ${SHAREMODE} is 444.

[ler]

address Adam's comments.
new poudriere
http://home.lerctr.org:8888/data/pHEADamd64-ler-checkout/2017-01-15_18h58m59s/logs/sonar-ant-task-2.5.log

[ler]

how about we upload the right diff.....

[adamw]

Makefile

31 ↗

(On Diff #24050)

%% is for passing variables to an external pkg-plist. You're building it in the Makefile, so you should be using ${DATADIR_REL}.

41 ↗

(On Diff #24050)

${STAGEDIR}${DATADIR}

[ler]

Address Adam's comment.

[ler]

Really address ALL Adam's comments.
I'll learn.

[ler]

Thou shalt not lose the x bit on the directory.
just chmod the file(s).

[adamw]

Approved but just remove the CHMOD line altogether.

[ler]

don't chmod the file, ${INSTALL_DATA} does it.