Page MenuHomeFreeBSD

Fix sysutils/lsof build on arm
ClosedPublic

Authored by ler on Jan 14 2017, 3:43 PM.

Details

Summary

Fix sysutils/lsof on arm.

This fixes the case where ARM_NARCH and ARM_NMMUS are 0, since the lsof(1) sources get hacky
access to kernel structures.

PR: 216065
Submitted by: samm os2 kiev ua
Approved by: (adamw|rene) (Mentor)

Test Plan

poudriere (ok)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6762
Build 6976: arc lint + arc unit

Event Timeline

ler retitled this revision from to Fix sysutils/lsof build on arm.
ler updated this object.
ler edited the test plan for this revision. (Show Details)
ler added reviewers: adamw, rene.

Move PORTREVISION line to where it belongs.

Please see my comment in the PR. I don't think this is the optimal solution to this problem. If we can't figure out the right way to do it then I'm okay with this as a backup plan but I'd like to see the problem corrected the right way first.

In particular, lsof is not a kernel module and so defining KLD_MODULE doesn't seem right.

adamw edited edge metadata.

Approved but you need to modify your commit message.

Larry you need to stop giving commit messages that start with lower-case levels. I'm going to start rejecting diffs that have that. Start with an upper-case, and include a quick sentence on WHY this patch fixes the arm build.

Also, for submitter email addresses, it's generally preferable to remove the formatting so that their address isn't spam-harvested as easily. So "ler FreeBSD org" is preferable to "ler@FreeBSD.org".

This revision is now accepted and ready to land.Jan 14 2017, 7:23 PM
ler edited edge metadata.
ler updated this object.
This revision was automatically updated to reflect the committed changes.