Fix sysutils/lsof on arm.
This fixes the case where ARM_NARCH and ARM_NMMUS are 0, since the lsof(1) sources get hacky
access to kernel structures.
PR: 216065
Submitted by: samm os2 kiev ua
Approved by: (adamw|rene) (Mentor)
Details
Details
- Reviewers
adamw rene - Commits
- rP431492: Fix sysutils/lsof on arm.
poudriere (ok)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please see my comment in the PR. I don't think this is the optimal solution to this problem. If we can't figure out the right way to do it then I'm okay with this as a backup plan but I'd like to see the problem corrected the right way first.
In particular, lsof is not a kernel module and so defining KLD_MODULE doesn't seem right.
Comment Actions
Approved but you need to modify your commit message.
Larry you need to stop giving commit messages that start with lower-case levels. I'm going to start rejecting diffs that have that. Start with an upper-case, and include a quick sentence on WHY this patch fixes the arm build.
Also, for submitter email addresses, it's generally preferable to remove the formatting so that their address isn't spam-harvested as easily. So "ler FreeBSD org" is preferable to "ler@FreeBSD.org".