sfxge(4): treat EFX_LINK_UNKOWN as link down
ClosedPublic
Actions

Authored by arybchik on Jan 6 2017, 8:26 AM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS311639: sfxge(4): treat EFX_LINK_UNKOWN as link down

Summary

It is safer to consider EFX_LINK_UNKNOWN as link down.
link_mode is set to EFX_LINK_UNKNOWN on port stop and fini.

It fixes kernel crash on module unload and lagg is up over sfxge
interface(s).

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

module build tested, module loaded/unload, interface up/down,
lagg creation/destruction, traffic with and without lagg

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 23649.Jan 6 2017, 8:26 AM

arybchik retitled this revision from to sfxge(4): treat EFX_LINK_UNKOWN as link down.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptJan 6 2017, 8:26 AM

philip accepted this revision.Jan 6 2017, 9:01 AM

philip edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2017, 9:01 AM

Closed by commit rS311639: sfxge(4): treat EFX_LINK_UNKOWN as link down (authored by arybchik). · Explain WhyJan 7 2017, 10:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

sfxge.h

4 lines

Diff 23701

View Options

head/sys/dev/sfxge/sfxge.h

sfxge(4): treat EFX_LINK_UNKOWN as link downClosedPublicActions