Put proper prototypes in tcpd.h
ClosedPublic
Actions

Authored by dim on Jan 5 2017, 8:05 PM.

Details

Reviewers

emaste
pfg

Commits

rS311459: Put proper prototypes in tcpd.h

Summary

Clang 4.0.0 complains about tcpd.h's not-really-prototypes, e.g.:

/usr/include/tcpd.h:75:24: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
extern int hosts_access();              /* access control */
                       ^

Add prototypes using __P, since that is what was done in other
tcpwrapper headers.

While here, garbage collect the incompatible rfc931() function from
scaffold.c, as it is never used.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 6578
Build 6798: arc lint + arc unit

Event Timeline

dim updated this revision to Diff 23636.Jan 5 2017, 8:05 PM

dim retitled this revision from to Put proper prototypes in tcpd.h.

dim updated this object.

dim edited the test plan for this revision. (Show Details)

dim added reviewers: emaste, pfg.

Herald added a subscriber: imp. · View Herald TranscriptJan 5 2017, 8:05 PM

I really think we shouldn't bother with __P(), it's an anachronism that shouldn't persist. It's only in tli-sequent.h now I think? I'm happy to clean it out of there.