sfxge(4): cleanup: check deferred packet list tunables once

[arybchik]

Summary

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested

head/sys/dev/sfxge/sfxge_tx.c

if (txq_node == NULL) {
                 rc = ENOMEM;
                 goto fail_txq_node;
         }
 
         if (type == SFXGE_TXQ_IP_TCP_UDP_CKSUM &&
             (rc = tso_init(txq)) != 0)
                 goto fail3;
 
-        if (sfxge_tx_dpl_get_max <= 0) {
-                log(LOG_ERR, "%s=%d must be greater than 0",
-                    SFXGE_PARAM_TX_DPL_GET_MAX, sfxge_tx_dpl_get_max);
-                rc = EINVAL;
-                goto fail_tx_dpl_get_max;
-        }
-        if (sfxge_tx_dpl_get_non_tcp_max <= 0) {
-                log(LOG_ERR, "%s=%d must be greater than 0",
-                    SFXGE_PARAM_TX_DPL_GET_NON_TCP_MAX,
-                    sfxge_tx_dpl_get_non_tcp_max);
-                rc = EINVAL;
-                goto fail_tx_dpl_get_max;
-        }
-        if (sfxge_tx_dpl_put_max < 0) {
-                log(LOG_ERR, "%s=%d must be greater or equal to 0",
-                    SFXGE_PARAM_TX_DPL_PUT_MAX, sfxge_tx_dpl_put_max);
-                rc = EINVAL;
-                goto fail_tx_dpl_put_max;
-        }
-
         /* Initialize the deferred packet list. */
         stdp = &txq->dpl;
         stdp->std_put_max = sfxge_tx_dpl_put_max;
         stdp->std_get_max = sfxge_tx_dpl_get_max;
         stdp->std_get_non_tcp_max = sfxge_tx_dpl_get_non_tcp_max;
         stdp->std_getp = &stdp->std_get;
 
         SFXGE_TXQ_LOCK_INIT(txq, device_get_nameunit(sc->dev), txq_index);
sfxge_tx_qinit(struct sfxge_softc *sc, unsigned int txq_index,
         txq->txq_index = txq_index;
         txq->init_state = SFXGE_TXQ_INITIALIZED;
         txq->hw_vlan_tci = 0;
 
         return (0);
 
 fail_txq_stat_init:
 fail_dpl_node:
-fail_tx_dpl_put_max:
-fail_tx_dpl_get_max:
 fail3:
 fail_txq_node:
         free(txq->pend_desc, M_SFXGE);
 fail2:
         while (nmaps-- != 0)
                 bus_dmamap_destroy(txq->packet_dma_tag, txq->stmp[nmaps].map);
         free(txq->stmp, M_SFXGE);
         bus_dma_tag_destroy(txq->packet_dma_tag);
sfxge_tx_init(struct sfxge_softc *sc)
         int index;
         int rc;
 
         intr = &sc->intr;
 
         KASSERT(intr->state == SFXGE_INTR_INITIALIZED,
             ("intr->state != SFXGE_INTR_INITIALIZED"));
 
+        if (sfxge_tx_dpl_get_max <= 0) {
+                log(LOG_ERR, "%s=%d must be greater than 0",
+                    SFXGE_PARAM_TX_DPL_GET_MAX, sfxge_tx_dpl_get_max);
+                rc = EINVAL;
+                goto fail_tx_dpl_get_max;
+        }
+        if (sfxge_tx_dpl_get_non_tcp_max <= 0) {
+                log(LOG_ERR, "%s=%d must be greater than 0",
+                    SFXGE_PARAM_TX_DPL_GET_NON_TCP_MAX,
+                    sfxge_tx_dpl_get_non_tcp_max);
+                rc = EINVAL;
+                goto fail_tx_dpl_get_non_tcp_max;
+        }
+        if (sfxge_tx_dpl_put_max < 0) {
+                log(LOG_ERR, "%s=%d must be greater or equal to 0",
+                    SFXGE_PARAM_TX_DPL_PUT_MAX, sfxge_tx_dpl_put_max);
+                rc = EINVAL;
+                goto fail_tx_dpl_put_max;
+        }
+
         sc->txq_count = SFXGE_TXQ_NTYPES - 1 + sc->intr.n_alloc;
 
         sc->tso_fw_assisted = sfxge_tso_fw_assisted;
         if ((~encp->enc_features & EFX_FEATURE_FW_ASSISTED_TSO) ||
             (!encp->enc_fw_assisted_tso_enabled))
                 sc->tso_fw_assisted &= ~SFXGE_FATSOV1;
         if ((~encp->enc_features & EFX_FEATURE_FW_ASSISTED_TSO_V2) ||
             (!encp->enc_fw_assisted_tso_v2_enabled))
fail3:
         sfxge_tx_qfini(sc, SFXGE_TXQ_IP_CKSUM);
 
 fail2:
         sfxge_tx_qfini(sc, SFXGE_TXQ_NON_CKSUM);
 
 fail:
 fail_txq_node:
         sc->txq_count = 0;
+fail_tx_dpl_put_max:
+fail_tx_dpl_get_non_tcp_max:
+fail_tx_dpl_get_max:
         return (rc);
 }