sfxge(4): don't use TX descriptor push with TSO option descriptors
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 4:17 PM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS310754: sfxge(4): don't use Tx descriptor push with TSO option descriptors

Summary

It is not safe to push TSO option descriptors if pacer bypass is
enabled, so to make sure that doesn't happen never push TSO option
descriptors.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 23340.Dec 28 2016, 4:17 PM

arybchik retitled this revision from to sfxge(4): don't use TX descriptor push with TSO option descriptors.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 4:17 PM

gnn accepted this revision.Dec 28 2016, 4:45 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Dec 28 2016, 4:45 PM

Closed by commit rS310754: sfxge(4): don't use Tx descriptor push with TSO option descriptors (authored by arybchik). · Explain WhyDec 29 2016, 7:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

ef10_tx.c

56 lines

Diff 23376

View Options

head/sys/dev/sfxge/common/ef10_tx.c

sfxge(4): don't use TX descriptor push with TSO option descriptorsClosedPublicActions