sfxge(4): limit max TXQ size on Medford to 2048
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 3:50 PM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS342480: MFC r340767
rS342407: MFC r340767
rS342303: MFC r340767
rS340767: sfxge(4): limit max TXQ size on Medford to 2048

Summary

Queues with 4096 descriptors are not supported as the top bit is used
for vfifo stuffing.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 23336.Dec 28 2016, 3:50 PM

arybchik retitled this revision from to sfxge(4): limit max TXQ size on Medford to 2048.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 3:50 PM

gnn requested changes to this revision.Dec 28 2016, 4:43 PM

gnn edited edge metadata.

gnn added inline comments.

head/sys/dev/sfxge/common/siena_nic.c
161	Please create a #defined constant for this.

This revision now requires changes to proceed.Dec 28 2016, 4:43 PM

arybchik added inline comments.Dec 29 2016, 9:55 AM

head/sys/dev/sfxge/common/siena_nic.c
161	Do you mean exactly this one or all similar cases above as well? The define will be used in exactly one place since logically it is different constants for different NIC families.

gnn added inline comments.Dec 29 2016, 5:28 PM

head/sys/dev/sfxge/common/siena_nic.c
161	Yes, I'd like to see it for all cases so that none of them are magic numbers. I noticed this one first.

Rebase

Harbormaster completed remote builds in B20919: Diff 50659.Nov 21 2018, 11:05 AM

Requested changes will be done in subsequent patches since it is too much headache to fix it here out of order and have pile of merge conflicts in subsequent patches.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2018, 4:15 PM

Closed by commit rS340767: sfxge(4): limit max TXQ size on Medford to 2048 (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.