sfxge(4): fix GET_RXDP_CONFIG usage for multi-PF on Medford
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 1:18 PM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS310715: sfxge(4): fix GET_RXDP_CONFIG usage for multi-PF on Medford

Summary

On Medford, using MC_CMD_GET_RXDP_CONFIG to query the RX end
padding setting is in the ADMIN group, and so fails for
unprivileged functions. In that case, assume the largest size
supported by Medford hardware (256bytes) to prevent overrun.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 23318.Dec 28 2016, 1:18 PM

arybchik retitled this revision from to sfxge(4): fix GET_RXDP_CONFIG usage for multi-PF on Medford.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 1:18 PM

gnn accepted this revision.Dec 28 2016, 4:32 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Dec 28 2016, 4:32 PM

Closed by commit rS310715: sfxge(4): fix GET_RXDP_CONFIG usage for multi-PF on Medford (authored by arybchik). · Explain WhyDec 28 2016, 5:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

medford_nic.c

9 lines

Diff 23345

View Options

head/sys/dev/sfxge/common/medford_nic.c

sfxge(4): fix GET_RXDP_CONFIG usage for multi-PF on MedfordClosedPublicActions