Optimizations for kqueue timers.
ClosedPublic
Actions

Authored by kib on Dec 25 2016, 12:12 PM.

Details

Reviewers

markj
jmg
badger
jhb

Commits

rS310554: Some optimizations for kqueue timers.

Summary

There is no need to do two allocations per kqueue timer. Gather all data needed by the timer callout into the structure and allocate it at once.

Use the structure to preserve the result of timer2sbintime(), to not perform 64bit calculations in callout.

Style.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib updated this revision to Diff 23251.Dec 25 2016, 12:12 PM

kib retitled this revision from to Optimizations for kqueue timers..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added reviewers: markj, jhb, badger.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: jmg. · View Herald TranscriptDec 25 2016, 12:12 PM

Herald added a subscriber: imp. · View Herald Transcript

Looks like you can get rid of the p_nexttime field too.

This revision is now accepted and ready to land.Dec 25 2016, 7:09 PM

Closed by commit rS310554: Some optimizations for kqueue timers. (authored by kib). · Explain WhyDec 25 2016, 7:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_event.c

52 lines

sys/

event.h

1 line

Diff 23256

View Options

head/sys/kern/kern_event.c