Page MenuHomeFreeBSD
Differential D8878

Various improvements to vm_page_alloc_contig()
ClosedPublic
Actions

Authored by alc on Dec 21 2016, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 6:35 AM
Unknown Object (File)
Sep 23 2024, 3:21 PM
Unknown Object (File)
Sep 1 2024, 3:12 PM
Unknown Object (File)
Aug 31 2024, 7:44 AM
Unknown Object (File)
Aug 18 2024, 10:46 AM
Unknown Object (File)
Aug 12 2024, 3:31 AM
Unknown Object (File)
Aug 6 2024, 7:49 AM
Unknown Object (File)
Jul 26 2024, 6:46 AM
View All 57 Files
Subscribers
pho

Details

Reviewers
kib
markj
Commits
rS310720: Relax the object type restrictions on vm_page_alloc_contig(). Specifically,
Summary

Relax the object type restrictions on vm_page_alloc_contig(). Specifically, add support for object types that were previously prohibited because they could contain PG_CACHED pages.

Roughly halve the number of radix trie operations performed by vm_page_alloc_contig() using the same approach that is employed by vm_page_alloc(). Also, eliminate the radix trie lookup performed with the free page queues lock held.

Tidy up the handling of radix trie insert failures in vm_page_alloc() and vm_page_alloc_contig().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc updated this revision to Diff 23150.Dec 21 2016, 4:48 PM
alc retitled this revision from to Various improvements to vm_page_alloc_contig().
alc updated this object.
alc edited the test plan for this revision. (Show Details)
alc added reviewers: kib, markj.
kib accepted this revision.Dec 21 2016, 5:22 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2016, 5:22 PM
markj accepted this revision.Dec 21 2016, 5:33 PM
markj edited edge metadata.
alc edited edge metadata.Dec 21 2016, 5:54 PM
alc added a subscriber: pho.

Peter, could you please test this patch?

pho added a comment.Dec 21 2016, 6:21 PM
In D8878#183786, @alc wrote:

Peter, could you please test this patch?

Sure.

pho added a comment.Dec 22 2016, 9:16 PM
In D8878#183788, @pho wrote:
In D8878#183786, @alc wrote:

Peter, could you please test this patch?

Sure.

Ran stress2 on a mix of i386 and amd64.
No problems seen.

Closed by commit rS310720: Relax the object type restrictions on vm_page_alloc_contig(). Specifically, (authored by alc). · Explain WhyDec 28 2016, 6:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
88 lines
2 lines
15 lines

Diff 23351

View Options

head/sys/vm/vm_page.c

Loading...
View Options

head/sys/vm/vm_reserv.h

Loading...
View Options

head/sys/vm/vm_reserv.c

Loading...