Page MenuHomeFreeBSD
Differential D8821

aw_clk honor CLK_SET_DRYRUN
ClosedPublic
Actions

Authored by manu on Dec 16 2016, 7:21 PM.
Tags
Referenced Files
F151905210: D8821.id23015.diff
Sat, Apr 11, 11:26 AM
Unknown Object (File)
Wed, Apr 8, 4:48 AM
Unknown Object (File)
Sun, Apr 5, 7:18 PM
Unknown Object (File)
Sat, Mar 28, 8:31 AM
Unknown Object (File)
Tue, Mar 24, 11:40 AM
Unknown Object (File)
Mon, Mar 16, 7:58 PM
Unknown Object (File)
Sun, Mar 15, 2:51 PM
Unknown Object (File)
Sun, Mar 15, 7:49 AM
View All Files
Subscribers
andrew
imp

Details

Reviewers
jmcneill
Group Reviewers
ARM
Commits
rS310178: Honor the CLK_SET_DRYRUN for the *set_freq function for allwinner clocks.
Summary

Honor the CLK_SET_DRYRUN for the *set_freq function for allwinner clocks.

Test Plan

Tested on A20 SOM EVB

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu updated this revision to Diff 23008.Dec 16 2016, 7:21 PM
manu retitled this revision from to aw_clk honor CLK_SET_DRYRUN.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added reviewers: ARM, jmcneill.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptDec 16 2016, 7:21 PM
jmcneill added inline comments.Dec 16 2016, 8:19 PM
sys/arm/allwinner/clk/aw_debeclk.c
215 ↗(On Diff #23008)

if ((flags & CLK_SET_DRYRUN) != 0)

sys/arm/allwinner/clk/aw_lcdclk.c
421 ↗(On Diff #23008)

Why fetch parent_clk freq twice?

manu updated this revision to Diff 23015.Dec 16 2016, 8:30 PM
manu removed rS FreeBSD src repository - subversion as the repository for this revision.

Remove copy/paste error and explicitly compare flags with dryrun.

manu marked 2 inline comments as done.Dec 16 2016, 8:31 PM
jmcneill accepted this revision.Dec 16 2016, 9:36 PM
jmcneill edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 9:36 PM
Closed by commit rS310178: Honor the CLK_SET_DRYRUN for the *set_freq function for allwinner clocks. (authored by manu). · Explain WhyDec 16 2016, 9:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
allwinner/
clk/
9 lines
9 lines
87 lines
85 lines
30 lines
24 lines
3 lines

Diff 23017

View Options

head/sys/arm/allwinner/clk/aw_debeclk.c

Loading...
View Options

head/sys/arm/allwinner/clk/aw_hdmiclk.c

Loading...
View Options

head/sys/arm/allwinner/clk/aw_lcdclk.c

Loading...
View Options

head/sys/arm/allwinner/clk/aw_mmcclk.c

Loading...
View Options

head/sys/arm/allwinner/clk/aw_modclk.c

Loading...
View Options

head/sys/arm/allwinner/clk/aw_pll.c

Loading...
View Options

head/sys/arm/allwinner/clk/aw_thsclk.c

Loading...