Page MenuHomeFreeBSD

aw_clk honor CLK_SET_DRYRUN
ClosedPublic

Authored by manu on Dec 16 2016, 7:21 PM.

Details

Summary

Honor the CLK_SET_DRYRUN for the *set_freq function for allwinner clocks.

Test Plan

Tested on A20 SOM EVB

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu updated this revision to Diff 23008.Dec 16 2016, 7:21 PM
manu retitled this revision from to aw_clk honor CLK_SET_DRYRUN.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added reviewers: ARM, jmcneill.
manu set the repository for this revision to rS FreeBSD src repository.
manu added a project: ARM.
jmcneill added inline comments.Dec 16 2016, 8:19 PM
sys/arm/allwinner/clk/aw_debeclk.c
215 ↗(On Diff #23008)

if ((flags & CLK_SET_DRYRUN) != 0)

sys/arm/allwinner/clk/aw_lcdclk.c
421 ↗(On Diff #23008)

Why fetch parent_clk freq twice?

manu updated this revision to Diff 23015.Dec 16 2016, 8:30 PM
manu removed rS FreeBSD src repository as the repository for this revision.

Remove copy/paste error and explicitly compare flags with dryrun.

manu marked 2 inline comments as done.Dec 16 2016, 8:31 PM
jmcneill accepted this revision.Dec 16 2016, 9:36 PM
jmcneill edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 9:36 PM
This revision was automatically updated to reflect the committed changes.