linuxkpi: Fix not-found case of linux_pci_find_irq_dev

[cem]

Summary

Linux list_for_each_entry() does not neccessarily end with the iterator
NULL (it may be an offset from NULL if the list member is not the first
element of the member struct). Also, initialize the iterator variable
to a sane value.

Reported by: Coverity
CID: 1366940

[cem]

Add missing &.

[adrian]

.. shouldn't the spin lock be before pdev = ?

-a

[• hselasky]

Hi,

I'd prefer if we didn't make dependencies on how list.h is implemented. Can you use the following approach?

struct device *retval = NULL;

...

retval = &pdev->dev;
break;

return (retval);

Thank you!

[cem]

In D8780#181843, @adrian wrote:

.. shouldn't the spin lock be before pdev = ?

Shouldn't matter — the list head doesn't move.

In D8780#181845, @hselasky wrote:

Hi,

I'd prefer if we didn't make dependencies on how list.h is implemented. Can you use the following approach?

struct device *retval = NULL;

...

retval = &pdev->dev;
break;

return (retval);

Thank you!

Yeah, that's fine (and was the alternate approach I had in mind).

[cem]

Don't depend on linux list implementation.

[• hselasky]

Don't forget to MFC to 11/10/9.