Paths

Table of Contentst

Differential D8769

Switch Rockchip RK3188 SoC to use the platform code
ClosedPublic
Actions

Authored by ganbold on Dec 13 2016, 10:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 29, 11:05 AM

	Unknown Object (File)
	Mon, Jan 27, 5:46 PM

	Unknown Object (File)
	Fri, Jan 24, 6:02 PM

	Unknown Object (File)
	Tue, Jan 21, 5:53 PM

	Unknown Object (File)
	Dec 15 2024, 5:21 AM

	Unknown Object (File)
	Dec 8 2024, 12:31 PM

	Unknown Object (File)
	Nov 24 2024, 4:31 PM

	Unknown Object (File)
	Nov 24 2024, 4:02 PM

View All 100 Files

Subscribers

Details

Reviewers

Commits

rS310019: Switch Rockchip RK3188 SoC to use the platform code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ganbold updated this revision to Diff 22862.Dec 13 2016, 10:42 AM

ganbold retitled this revision from to Switch Rockchip RK3188 SoC to use the platform code.

ganbold updated this object.

ganbold edited the test plan for this revision. (Show Details)

ganbold added a reviewer: andrew.

ganbold set the repository for this revision to rS FreeBSD src repository - subversion.

ganbold added a subscriber: ARM.

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2016, 10:42 AM

Include changes to RK3188 config

manu added a subscriber: manu.Dec 13 2016, 10:51 AM

manu added inline comments.

sys/arm/rockchip/rk30xx_machdep.c
93 ↗	(On Diff #22862)	It should be in a #ifdef SOC_RK3188
98 ↗	(On Diff #22862)	#ifdef SMP

Added SOC_ROCKCHIP_RK3188 option.

Added SOC_ROCKCHIP_RK3188 option and SMP check.

Consider my comments as suggestions for future improvements.

/usr/src/sys/conf/options.arm
67 ↗	(On Diff #22865)	I'm wondering if we should start moving to `opt_soc.h` on arm.
sys/arm/conf/RK3188
26 ↗	(On Diff #22865)	There seems to be inconsistent indenting here.
sys/arm/rockchip/rk30xx_machdep.c
55–60 ↗	(On Diff #22865)	This should probably be the default implementation

This revision is now accepted and ready to land.Dec 13 2016, 11:16 AM

Closed by commit rS310019: Switch Rockchip RK3188 SoC to use the platform code. (authored by ganbold). · Explain WhyDec 13 2016, 11:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

conf/

5 lines

rockchip/

rk30xx_machdep.c

50 lines

38 lines

8 lines

conf/

1 line

Diff 22866

head/sys/arm/conf/RK3188

Loading...

head/sys/arm/rockchip/rk30xx_machdep.c

Loading...

head/sys/arm/rockchip/rk30xx_mp.h

Loading...

head/sys/arm/rockchip/rk30xx_mp.c

Loading...

head/sys/conf/options.arm

Loading...