Add sysutils/cmocka

[dteske]

Summary

Add sysutils/cmocka - a fork for Google's cmockery unit testing framework

Test Plan

Make sure it compiles and installs

[shurd]

sysutils/cmocka/Makefile

34 ↗

(On Diff #22603)

You should be able to use STATIC_CMAKE_ON here...

[shurd]

sysutils/cmocka/Makefile

17 ↗

(On Diff #22603)

Hrm... is the plist the same regardless of the STATIC option? You may need %%NO_STATIC%% or %%STATIC%% for some and use OPTIONS_SUB= STATIC

[shurd]

Looks like you're using spaces, not tabs. ``portlint -C'' is your friend.

sysutils/cmocka/Makefile

7 ↗

(On Diff #22603)

This line cam be removed since you have USES=tar:xz

[shurd]

sysutils/cmocka/Makefile

30 ↗

(On Diff #22603)

I don't think you really need to override the default "Build static executables and/or libraries" especially since this port doesn't seem to have executables.

[shurd]

Makefile740 BDownload

Quickly cleaned up makefile.

This still doesn't address portlint "no ftp/http mirror in MASTER_SITES for users behind a proxy." warning. Maybe a copy in your public_distfiles?

[dteske]

In D8673#179786, @shurd wrote:

Makefile740 BDownload

Quickly cleaned up makefile.

This still doesn't address portlint "no ftp/http mirror in MASTER_SITES for users behind a proxy." warning. Maybe a copy in your public_distfiles?

It looks like portlint doesn't like https. I changed https to http because the distsite redirects http traffic to https anyhow. Changing https to http makes portlint happy.

sysutils/cmocka/Makefile

17 ↗

(On Diff #22603)

Ended up using STATIC_PLIST_FILES= lib/libcmocka.a
Also added standard trope: OPTIONS_SUB= yes

[dteske]

Incorporated feedback from shurd@ -- many thanks

[dteske]

Mark latest comments done

[shurd]

sysutils/cmocka/Makefile

6 ↗

(On Diff #22630)

This should still be https:// since that seems to be the only way it's fetchable. Adding a LOCAL/dteske source is likely the best option as long as public_distfiles works for non-ports committers (I hear it does).

[dteske]

+ Uploaded distfile to freefall:~dteske/public_distfiles
+ Added LOCAL/dteske to MASTER_SITES
+ Put primary MASTER_SITE back to https (http just redirects to https)
+ portlint says "looks fine."

[dteske]

Mark recent nits as done

[shurd]

Looks good, approved for commit.

Test commit using:

Tools/scripts/addport -L -1 -s ~/fbsd/ports/head/distfiles -anty -d sysutils/cmocka

Then do the commit using:

Tools/scripts/addport -L -1 -s ~/fbsd/ports/head/distfiles -d sysutils/cmocka

Don't forget to add "Approved-by: shurd" to the commit message.

[mat]

It looks like portlint doesn't like https. I changed https to http because the distsite redirects http traffic to https anyhow. Changing https to http makes portlint happy.

Never make changes just to make portlint happy, portlint is a static lint tools, it does and says bad things, this is one of them.

sysutils/cmocka/Makefile

17 ↗

(On Diff #22603)

If you do not have a pkg-plist file, OPTIONS_SUB will not do anything.

sysutils/cmocka/distinfo

1–2 ↗

(On Diff #22632)

This must have been done with a very old ports tree, you will need to run make makesum to correct it.

[dteske]

Removed OPTIONS_SUB (thanks)

Updated ports tree from ~10.3-R (SVN r411747) to head (SVN r427513) and re-ran make makesum. Adding the TIMESTAMP entry at the top

[dteske]

Incorporate feedback from mat@

[shurd]

Approved for commit