Page MenuHomeFreeBSD

Build smbios.ko as a module for amd64 and i386
ClosedPublic

Authored by rpokala on Nov 21 2016, 10:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 19 2024, 1:13 PM
Unknown Object (File)
Feb 21 2024, 1:23 PM
Unknown Object (File)
Jan 8 2024, 8:30 AM
Unknown Object (File)
Dec 27 2023, 7:43 PM
Unknown Object (File)
Dec 27 2023, 7:35 PM
Unknown Object (File)
Dec 24 2023, 5:10 AM
Unknown Object (File)
Dec 20 2023, 1:41 AM
Unknown Object (File)
Dec 19 2023, 9:47 AM
Subscribers

Details

Summary

For whatever reason, smapi, smbios, vpd are all under the "bios" directory.
smapi is only for i386, so the entire "bios" directory is only built for
i386. Break smapi out, and make only it i386-specific. Then, build the
"bios" directory for both amd64 and i386.

Test Plan

make tinderbox
find ${MAKEOBJDIRPREFIX} -name smbios.ko -o -name vpd.ko -o -name smapi.ko | egrep '/GENERIC/'

Before: All three are present for i386.i386, and none are present for any other platform.

After: All three are present for i386.i386 and pc98.i386, and smbios.ko and vpd.ko are present for amd64.amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rpokala retitled this revision from to Build smbios.ko as a module for amd64 and i386.
rpokala updated this object.
rpokala edited the test plan for this revision. (Show Details)

As long as these modules work on amd64, seems reasonable!

rpokala added a reviewer: imp.
rpokala edited the test plan for this revision. (Show Details)
rpokala added a reviewer: rpokala.

@imp approved this on IRC last night:

19:24:34 rpokala: bsdimp: if you're around, please review D8609 when you have a sec
19:24:36 rpokala: thanks!
19:24:55 bsdimp: k
19:26:45 bsdimp: rpokala, looks great.
19:26:51 bsdimp: rpokala, I can't login.
19:28:20 rpokala: bsdimp: well foo
19:28:58 rpokala: i gotta head home anyway; if you can figure it out, great; if not, i'll note that you approved it "verbally" and check it in when i get home
19:29:08 rpokala: thanks!

Marking this "accepted" on his behalf.

This revision is now accepted and ready to land.Dec 3 2016, 5:43 PM
This revision was automatically updated to reflect the committed changes.