Replace EFI part devices.

[tsoome]

Summary

partX: devices are unfortunately not so informative, so this patch is an
attempt to use existing partitioning code to present the devices in more
user friendly way.

Test Plan

I have tested this code on illumos (where it was originally developed), with
usb/cd/disk boot. However, the same series of tests should be
performed on freebsd as well.

[allanjude]

sys/boot/common/disk.c

283 ↗

(On Diff #22351)

why would a disk_ioctl return NOTTY?

[imp]

There's another review out that goes a bit in the other direction. It creates a UEFI UFS driver for easier booting. Perhaps you can reconcile the two?

sys/boot/common/disk.c

283 ↗

(On Diff #22351)

because ENOTTY means "ioctl not supported"

[tsoome]

sys/boot/common/disk.c

283 ↗

(On Diff #22351)

Thats traditional way (esp. in stacked drivers) to say "I don't implement this stuff", so the next layer can answer instead. So when some another command is added, disk_ioctl will return ENOTTY and block driver can respond if it does implement it.

Note the disk_ioctl implementation this way is kind of hack, I did not want to add up just random command code - as in fbsd the headers are actually shared between kernel and loader, but this way I can get the partition size, and it [the size of the partition] can be really helpful in different scenarios.

[• lidl_pix.net]

sys/boot/efi/libefi/efipart.c

463 ↗

(On Diff #22351)

Indentation needed.

469 ↗

(On Diff #22351)

This looks like a leftover debugging printf().

[tsoome]

In D8581#178131, @imp wrote:

There's another review out that goes a bit in the other direction. It creates a UEFI UFS driver for easier booting. Perhaps you can reconcile the two?

you mean the one implementing efi file system layer? I dont think those two should necessarily be even conflicting, because as an human, you still would like to know what devices you have and where from you are booting from. This work does not touch the file systems, just the block devices behind the scenes.

[tsoome]

cstyle and leftover debug printf.

[tsoome]

validate od pointer in disk_ioctl.

[tsoome]

Filter out nested partitions. At least AMI does create device tree like:
../Sata(..)/HD(1,GPT,...)/HD(1,MBR,...) for PMBR entry.

We only need the disk device handles and first level partition to help
us to identify the disk, we can just ignore nested partitions.

Adjust the device name printout on verbose lsdev to make it easier to read.

[tsoome]

Updated to revision 311995.

[imp]

I think this is fine. Nothing is leaping out at me

[tsoome]

rebase on r312374, updated the NULL checks on efi_devpath_last_node()
and efi_devpath_trim().

[tsoome]

svn update to 313329

[allanjude]

Approved for commit