Page MenuHomeFreeBSD

elfutils: Fix build on CURRENT
ClosedPublic

Authored by cem on Nov 8 2016, 6:46 PM.

Details

Summary

CURRENT added a #define for basename, which conflicts with elfutils'. Undefine
it before defining ours.

Test Plan

It builds successfully. I need a port committer's blessing to commit.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem retitled this revision from to elfutils: Fix build on CURRENT.Nov 8 2016, 6:46 PM
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: bapt, mat, bdrewery, AMDmi3.
cem updated this revision to Diff 22094.
cem updated this revision to Diff 22095.Nov 8 2016, 7:18 PM

Be sure to build nicely on 11.0 and 10.x too.

bapt edited edge metadata.Nov 11 2016, 1:23 AM
bapt accepted this revision.

You do not need to bump port revision as the build is failing and you changes are not modifying the binaries where it actually builds

This revision is now accepted and ready to land.Nov 11 2016, 1:23 AM
This revision was automatically updated to reflect the committed changes.