elfutils: Fix build on CURRENT
ClosedPublic
Actions

Authored by cem on Nov 8 2016, 6:46 PM.

Tags

None

Referenced Files

	F154329249: D8476.id22148.diff
	Mon, Apr 27, 9:26 PM

	Unknown Object (File)
	Thu, Apr 23, 8:34 PM

	Unknown Object (File)
	Tue, Apr 21, 11:37 PM

	Unknown Object (File)
	Sun, Apr 19, 1:42 AM

	Unknown Object (File)
	Sat, Apr 18, 1:20 AM

	Unknown Object (File)
	Fri, Apr 17, 4:36 AM

	Unknown Object (File)
	Fri, Apr 17, 4:36 AM

	Unknown Object (File)
	Fri, Apr 17, 4:35 AM

View All Files

Subscribers

None

Details

Reviewers

AMDmi3
bapt
bdrewery
mat

Commits

rP425895: elfutils: Fix build on CURRENT

Summary

CURRENT added a #define for basename, which conflicts with elfutils'. Undefine
it before defining ours.

Test Plan

It builds successfully. I need a port committer's blessing to commit.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 22094.Nov 8 2016, 6:46 PM

cem retitled this revision from to elfutils: Fix build on CURRENT.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: bapt, mat, bdrewery, AMDmi3.

Be sure to build nicely on 11.0 and 10.x too.

You do not need to bump port revision as the build is failing and you changes are not modifying the binaries where it actually builds

This revision is now accepted and ready to land.Nov 11 2016, 1:23 AM

Closed by commit rP425895: elfutils: Fix build on CURRENT (authored by cem). · Explain WhyNov 11 2016, 5:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

devel/

elfutils/

files/

patch-lib_eu-config.h

5 lines

Diff 22148

View Options

head/devel/elfutils/files/patch-lib_eu-config.h

elfutils: Fix build on CURRENTClosedPublicActions