Page MenuHomeFreeBSD

Adding 65 missing versions from HEAD and stable/*
ClosedPublic

Authored by mat on Nov 8 2016, 3:33 PM.

Details

Summary

There are a few entries where the committer did not bother explaining what his
commit was doing, so I did not bother reading the diff to figure out what was
in his head.

There has been a general trend lately of committing stuff in src, but not
bother to document the __FreeBSD_version bumps.

I hope this trend stops...

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat updated this revision to Diff 22088.Nov 8 2016, 3:33 PM
mat updated this revision to Diff 22089.
mat retitled this revision from to Adding 65 missing versions from HEAD and stable/*.
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: wblock, gjb.
  • typo.
gjb accepted this revision.Nov 8 2016, 4:33 PM
gjb edited edge metadata.

I did not check each __FreeBSD_version bump revision, but on cursory review, this looks fine.

This revision is now accepted and ready to land.Nov 8 2016, 4:33 PM
This revision was automatically updated to reflect the committed changes.
mat added a comment.Nov 8 2016, 5:10 PM
In D8473#176202, @gjb wrote:

I did not check each __FreeBSD_version bump revision, but on cursory review, this looks fine.

I sure hope you did not spend a day reviewing all those stuff, my eyes hurt from reading commit logs :-p

I'm going to commit this as-is.

What would be the best course of action to remind source committers that when they bump __FreeBSD_version, they *really* should commit to this file, like they used to do. (Out of the 65 missing versions, 50 or so are from 2016)

gjb added a comment.Nov 8 2016, 5:16 PM
In D8473#176218, @mat wrote:

What would be the best course of action to remind source committers that when they bump __FreeBSD_version, they *really* should commit to this file, like they used to do. (Out of the 65 missing versions, 50 or so are from 2016)

It is mentioned in the sys/sys/param.h file. :(

/*

  • __FreeBSD_version numbers are documented in the Porter's Handbook.
  • If you bump the version for any reason, you should update the documentation
  • there.
  • Currently this lives here in the doc/ repository: *
  • head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
mat added a comment.Nov 8 2016, 6:45 PM
In D8473#176219, @gjb wrote:
In D8473#176218, @mat wrote:

What would be the best course of action to remind source committers that when they bump __FreeBSD_version, they *really* should commit to this file, like they used to do. (Out of the 65 missing versions, 50 or so are from 2016)

It is mentioned in the sys/sys/param.h file. :(
/*

  • __FreeBSD_version numbers are documented in the Porter's Handbook.
  • If you bump the version for any reason, you should update the documentation
  • there.
  • Currently this lives here in the doc/ repository: *
  • head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml

I know, it is just that somehow, people stopped doing it :(