Page MenuHomeFreeBSD

Adding 65 missing versions from HEAD and stable/*
ClosedPublic

Authored by mat on Nov 8 2016, 3:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 1 2024, 5:31 AM
Unknown Object (File)
Feb 8 2024, 5:42 PM
Unknown Object (File)
Dec 20 2023, 1:40 AM
Unknown Object (File)
Nov 6 2023, 4:03 AM
Unknown Object (File)
Nov 5 2023, 3:38 PM
Unknown Object (File)
Nov 2 2023, 12:31 AM
Unknown Object (File)
Nov 1 2023, 4:09 AM
Unknown Object (File)
Oct 31 2023, 5:12 PM
Subscribers
None

Details

Summary

There are a few entries where the committer did not bother explaining what his
commit was doing, so I did not bother reading the diff to figure out what was
in his head.

There has been a general trend lately of committing stuff in src, but not
bother to document the __FreeBSD_version bumps.

I hope this trend stops...

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat updated this revision to Diff 22089.
mat retitled this revision from to Adding 65 missing versions from HEAD and stable/*.
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: wblock, gjb.
  • typo.
gjb edited edge metadata.

I did not check each __FreeBSD_version bump revision, but on cursory review, this looks fine.

This revision is now accepted and ready to land.Nov 8 2016, 4:33 PM
This revision was automatically updated to reflect the committed changes.
In D8473#176202, @gjb wrote:

I did not check each __FreeBSD_version bump revision, but on cursory review, this looks fine.

I sure hope you did not spend a day reviewing all those stuff, my eyes hurt from reading commit logs :-p

I'm going to commit this as-is.

What would be the best course of action to remind source committers that when they bump __FreeBSD_version, they *really* should commit to this file, like they used to do. (Out of the 65 missing versions, 50 or so are from 2016)

In D8473#176218, @mat wrote:

What would be the best course of action to remind source committers that when they bump __FreeBSD_version, they *really* should commit to this file, like they used to do. (Out of the 65 missing versions, 50 or so are from 2016)

It is mentioned in the sys/sys/param.h file. :(

/*

  • __FreeBSD_version numbers are documented in the Porter's Handbook.
  • If you bump the version for any reason, you should update the documentation
  • there.
  • Currently this lives here in the doc/ repository: *
  • head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
In D8473#176219, @gjb wrote:
In D8473#176218, @mat wrote:

What would be the best course of action to remind source committers that when they bump __FreeBSD_version, they *really* should commit to this file, like they used to do. (Out of the 65 missing versions, 50 or so are from 2016)

It is mentioned in the sys/sys/param.h file. :(

/*

  • __FreeBSD_version numbers are documented in the Porter's Handbook.
  • If you bump the version for any reason, you should update the documentation
  • there.
  • Currently this lives here in the doc/ repository: *
  • head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml

I know, it is just that somehow, people stopped doing it :(