Page MenuHomeFreeBSD

Make GNU diff and GNU grep optional
ClosedPublic

Authored by emaste on Oct 19 2016, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:46 PM
Unknown Object (File)
Thu, Nov 14, 4:18 PM
Unknown Object (File)
Mon, Nov 4, 6:39 AM
Unknown Object (File)
Oct 12 2024, 4:56 PM
Unknown Object (File)
Sep 24 2024, 7:55 PM
Unknown Object (File)
Sep 24 2024, 4:27 PM
Unknown Object (File)
Sep 19 2024, 11:06 PM
Unknown Object (File)
Sep 19 2024, 1:40 PM
Subscribers

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to Make GNU diff and GNU grep optional.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: bapt, imp.
emaste added inline comments.
share/mk/src.opts.mk
102

Note that this one is a little strange, in that I think we'll have the following result:

GNU_GREPBSD_GREPResult
nono/usr/bin/bsdgrep = BSD grep
noyes/usr/bin/grep = BSD grep
yesno/usr/bin/grep = GNU grep, /usr/bin/bsdgrep = BSD grep
yesyes/usr/bin/grep = BSD grep, /usr/bin/gnugrep = GNU grep
brooks added a reviewer: brooks.
brooks added inline comments.
share/mk/src.opts.mk
102

Maybe make WITHOUT_GNU_GREP + WITHOUT_BSD_GREP fatal?

This revision is now accepted and ready to land.Oct 20 2016, 12:15 AM
share/mk/src.opts.mk
102

I'm tempted to avoid trying to get too clever here; I think this change is primarily to allow experimentation with a gpl-free tree.

The build won't break WITHOUT_GNU_GREP and WITHOUT_BSD_GREP at least.

emaste edited edge metadata.

Connect OptionalObsoleteFiles

This revision now requires review to proceed.Oct 20 2016, 12:37 AM
This revision is now accepted and ready to land.Oct 20 2016, 3:20 PM