Integrate contrib/pjdfstest into the build

[ngie]

Summary

Integrate contrib/pjdfstest into the build

The proposed change installs pjdfstest to /usr/tests/sys/pjdfstest and integrates it
into Kyua.

The PJDFSTEST_FILESYSTEM environment variable is provided to run pjdfstest
on a separate filesystem outside of a designated sandbox. This is being provided
for end-users to test on separate filesystems, outside of $TMPDIR. Eventually
this variable should be replaced with a configuration variable which points to a
filesystem root ala kyua.conf and the command line.

X-MFC with: 272057
MFC after: 2 weeks
Sponsored by: EMC / Isilon Storage Division

[jmmv]

Quoting "The proposed change installs pjdfstest to /usr/tests/sys/pjdfstest, but does not integrate the test suite into Kyua."

What's the plan there? Are the changes to hook the tests into the test suite coming up very soon? If yes, doing this is not a big problem othat than the changes seeming to come in the "wrong order". If not, I wouldn't like to set precedent by installing stuff in /usr/tests that is not runnable as part of the test suite.

[ngie]

In D824#4, @jmmv wrote:

Quoting "The proposed change installs pjdfstest to /usr/tests/sys/pjdfstest, but does not integrate the test suite into Kyua."

What's the plan there? Are the changes to hook the tests into the test suite coming up very soon? If yes, doing this is not a big problem othat than the changes seeming to come in the "wrong order". If not, I wouldn't like to set precedent by installing stuff in /usr/tests that is not runnable as part of the test suite.

The goal was to get this in ASAP as it would be a move forward with building/running pjdfstest, however I'm willing to go with a batch of commits to make the window for picking up the non-Kyua integrated piece small (in particular because it would avoid me having to add entries to OptionalObsoleteFiles.inc).

Long story short, pjdfstest needs a path to test on. Traditional (documented) execution is:

cd /path/to/filesystem/under/test && prove -rv /path/to/pjdfstest

• /path/to/filesystem/under/test is most likely outside of kyua's sandbox.
• pjdfstest should _not_ be run by default [without setting up memory disks] to avoid tainting an existing filesystem too much because there are instances where it's extremely difficult to recover if pjdfstest goes off the rails (which has happened before in the past for me -- mostly dealing with an almost full filesystem, etc).

I didn't get a solid consensus on the variable name for "/path/to/filesystem/under/test", but I'll just put pick a name, document it, put it up for review, and commit the change with pjdfstest integrated into kyua.

[ngie]

tests/sys/pjdfstest/tests/chflags/Makefile

19

This line will be removed in the committed diff.

[ngie]

A final version of the pjdfstest integration was committed in r274016 -- in particular I fixed a really silly bug in tests/sys/pjdfstest/Makefile where it was installing an empty Kyuafile (because it used bsd.test.mk instead of bsd.subdir.mk), overwriting the copy generated by tests/sys/pjdfstest/tests/Makefile, in some cases.

Thanks for the earlier input!