Keep keyboard mode and state and restore it when switching window
ClosedPublic
Actions

Authored by dumbbell on Sep 23 2014, 6:30 PM.

Details

Reviewers

ray
nwhitehorn
emaste

Commits

rS273103: vt(4): Save/restore keyboard mode & LED states when switching window
rS273036: vt(4): Save/restore keyboard mode & LED states when switching window
rS272416: vt(4): Save/restore keyboard mode & LED states when switching window

Summary

Currently, the scroll lock state of the keyboard isn't restored properly when switching window. The patch copies syscons' behavior.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell updated this revision to Diff 1736.Sep 23 2014, 6:30 PM

dumbbell retitled this revision from to Keep keyboard mode and state and restore it when switching window.

dumbbell updated this object.

dumbbell edited the test plan for this revision. (Show Details)

dumbbell added reviewers: ray, emaste, nwhitehorn.

That is what I have to done while ago :)
One comment - there is last `kbdd_ioctl(...KDSKBMODE...) in the vtterm_cngetc, so looks like grab/ungrab have to save/restore kbdstate of current window too. (I'm not sure)

Thanks a lot!

This revision is now accepted and ready to land.Sep 24 2014, 9:32 PM

This patch allows me to use the console right away after X shutdown. Before I would need to switch to another console before keyboard input would be registered.

Use vt_{update,save}_kbd_{mode,state} in vterm_cngetc() too.

Closed by commit rS272416 (authored by @dumbbell).

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

vt/

vt.h

1 line

vt_core.c

251 lines

Diff 1865

View Options

head/sys/dev/vt/vt.h