Remove extra space between point to point links and netmask in ifconfig output
ClosedPublic
Actions

Authored by kbowling on Oct 8 2016, 6:16 PM.

Details

Reviewers

hiren
allanjude
gnn
sbruno

Commits

rS306896: Fix spurious white space introduced in r301059

Summary

rS301059 introduced a subtle change for point to point interfaces where an extra space is inserted before the netmask. This can cause issues for scripts that parse ifconfig output.

Test Plan

After rS301059:

inet 169.254.2.1 --> 169.254.2.2  netmask 0xfffffffc

With this patch, return to :

inet 169.254.2.1 --> 169.254.2.2 netmask 0xfffffffc

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling updated this revision to Diff 21189.Oct 8 2016, 6:16 PM

kbowling retitled this revision from to Remove extra space between point to point links and netmask in ifconfig output.

kbowling updated this object.

kbowling edited the test plan for this revision. (Show Details)

kbowling added reviewers: allanjude, sbruno, gnn.

kbowling set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2016, 6:16 PM

Ouch, my bad.

Good catch, sadly this is obviously too late for 11.0 :(

This revision is now accepted and ready to land.Oct 8 2016, 6:29 PM

hiren accepted this revision.Oct 9 2016, 2:58 AM

hiren added a reviewer: hiren.

Closed by commit rS306896: Fix spurious white space introduced in r301059 (authored by allanjude). · Explain WhyOct 9 2016, 3:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

ifconfig/

af_inet.c

2 lines

af_inet6.c

2 lines

Diff 21196

View Options

head/sbin/ifconfig/af_inet.c