Add test for a musl libc memmem bug
ClosedPublic
Actions

Authored by emaste on Oct 3 2016, 5:15 PM.

Tags

None

Referenced Files

	F131725105: D8137.id20980.diff
	Fri, Oct 10, 4:18 PM

	Unknown Object (File)
	Fri, Sep 19, 6:32 AM

	Unknown Object (File)
	Thu, Sep 18, 10:16 PM

	Unknown Object (File)
	Tue, Sep 16, 7:29 PM

	Unknown Object (File)
	Mon, Sep 15, 1:25 PM

	Unknown Object (File)
	Mon, Sep 15, 7:25 AM

	Unknown Object (File)
	Mon, Sep 15, 6:52 AM

	Unknown Object (File)
	Sep 8 2025, 2:27 PM

View All 97 Files

Subscribers

None

Details

Reviewers

ngie
ed

Commits

rS306784: Add test for a musl libc memmem bug

Summary

With a short needle (aka little) musl's memmem could read past the end of the haystack (aka big). This was fixed in musl commit c718f9f.

Add this test in advance of migrating to musl's optimized strstr and memmem, in review D2601.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 20980.Oct 3 2016, 5:15 PM

emaste retitled this revision from to Add test for a musl libc memmem bug.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: ngie.

emaste added a reviewer: ed.Oct 5 2016, 5:21 PM

ed accepted this revision.Oct 5 2016, 5:36 PM

ed edited edge metadata.

This revision is now accepted and ready to land.Oct 5 2016, 5:36 PM

Closed by commit rS306784: Add test for a musl libc memmem bug (authored by emaste). · Explain WhyOct 6 2016, 8:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

lib/

libc/

string/

t_memmem.c

3 lines

Diff 20980

View Options

contrib/netbsd-tests/lib/libc/string/t_memmem.c

Add test for a musl libc memmem bugClosedPublicActions