Add test for a musl libc memmem bug
ClosedPublic
Actions

Authored by emaste on Oct 3 2016, 5:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 6:25 AM

	Unknown Object (File)
	Sun, Dec 15, 3:45 AM

	Unknown Object (File)
	Nov 26 2024, 5:39 PM

	Unknown Object (File)
	Nov 23 2024, 12:37 PM

	Unknown Object (File)
	Nov 22 2024, 11:44 AM

	Unknown Object (File)
	Nov 19 2024, 12:02 PM

	Unknown Object (File)
	Sep 30 2024, 6:53 PM

	Unknown Object (File)
	Sep 18 2024, 12:34 AM

View All 60 Files

Subscribers

None

Details

Reviewers

ngie
ed

Commits

rS306784: Add test for a musl libc memmem bug

Summary

With a short needle (aka little) musl's memmem could read past the end of the haystack (aka big). This was fixed in musl commit c718f9f.

Add this test in advance of migrating to musl's optimized strstr and memmem, in review D2601.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 20980.Oct 3 2016, 5:15 PM

emaste retitled this revision from to Add test for a musl libc memmem bug.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: ngie.

emaste added a reviewer: ed.Oct 5 2016, 5:21 PM

ed accepted this revision.Oct 5 2016, 5:36 PM

ed edited edge metadata.

This revision is now accepted and ready to land.Oct 5 2016, 5:36 PM

Closed by commit rS306784: Add test for a musl libc memmem bug (authored by emaste). · Explain WhyOct 6 2016, 8:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

contrib/

netbsd-tests/

lib/

libc/

string/

t_memmem.c

3 lines

Diff 21127

View Options

head/contrib/netbsd-tests/lib/libc/string/t_memmem.c

Add test for a musl libc memmem bugClosedPublicActions