Page MenuHomeFreeBSD
Differential D7984

elfdump: limit STDIN to no rights rather than closing it
ClosedPublic
Actions

Authored by emaste on Sep 20 2016, 7:15 PM.
Tags
None
Referenced Files
F133233151: D7984.id20551.diff
Fri, Oct 24, 4:42 AM
Unknown Object (File)
Wed, Oct 22, 7:38 PM
Unknown Object (File)
Wed, Oct 22, 9:04 AM
Unknown Object (File)
Wed, Oct 22, 9:04 AM
Unknown Object (File)
Tue, Oct 21, 8:39 PM
Unknown Object (File)
Sat, Oct 18, 3:42 AM
Unknown Object (File)
Sat, Oct 18, 1:33 AM
Unknown Object (File)
Sat, Oct 18, 1:00 AM
View All Files
Subscribers
None

Details

Reviewers
cem
oshogbo
Commits
rS306056: elfdump: limit STDIN to no rights rather than closing it
Summary

Closing stdin/stdout/stderr is often a bad idea as a future open() can end up with its fd. Leave STDIN_FILENO open and limit it to no rights instead.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 20551.Sep 20 2016, 7:15 PM
emaste retitled this revision from to elfdump: limit STDIN to no rights rather than closing it.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: oshogbo, cem.
cem accepted this revision.Sep 20 2016, 7:24 PM
cem edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2016, 7:24 PM
Closed by commit rS306056: elfdump: limit STDIN to no rights rather than closing it (authored by emaste). · Explain WhySep 20 2016, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
elfdump/
2 lines

Diff 20554

View Options

head/usr.bin/elfdump/elfdump.c

Loading...