Page MenuHomeFreeBSD

elfdump: limit STDIN to no rights rather than closing it
ClosedPublic

Authored by emaste on Sep 20 2016, 7:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 3:42 AM
Unknown Object (File)
Sat, Oct 18, 1:33 AM
Unknown Object (File)
Sat, Oct 18, 1:00 AM
Unknown Object (File)
Fri, Oct 10, 7:42 PM
Unknown Object (File)
Sun, Sep 28, 2:15 PM
Unknown Object (File)
Sun, Sep 28, 12:48 AM
Unknown Object (File)
Sat, Sep 27, 4:32 PM
Unknown Object (File)
Sat, Sep 27, 2:52 PM
Subscribers
None

Details

Summary

Closing stdin/stdout/stderr is often a bad idea as a future open() can end up with its fd. Leave STDIN_FILENO open and limit it to no rights instead.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to elfdump: limit STDIN to no rights rather than closing it.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: oshogbo, cem.
cem edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2016, 7:24 PM
This revision was automatically updated to reflect the committed changes.