security/john: Update to 1.8.0-jumbo-1

[woodsb02]

Summary

security/john: Update to 1.8.0-jumbo-1

• Fix MASTER_SITES as it was not downloading from primary server
• Build now uses GNU configure, set WRKSRC_SUBDIR
• No longer need to specify ALL_TARGET, as it is determined by configure
• Reformat patches (pet portlint)

Changes this release:

http://www.openwall.com/lists/john-users/2014/12/18/23

Test Plan

poudriere testport: ok on 12amd64, 9i386
portlint: looks fine

[woodsb02]

• Remove whitespace from end of line 21 in Makefile

[adamw]

If Alexey's good with it, I am too.

[danfe]

Ideally it would be very nice (that's actually my own requirement to myself) to decouple -jumbo patch (turn it into an option) and overhaul the port according to Alexander's comments:

http://www.openwall.com/lists/john-users/2012/01/08/4

I started to get my patches back into shape last month since users became increasingly demanding for newer version, but addressing all issues would take some time.

Perhaps as a nice smaller starting point would be to clear -jumbo suffix from the port version and turn it into an option (enabled by default). Or you can wait until I'd get back to my computer next week and do it myself. But please do not commit your patch as is since further work mighy very easily require a port epoch bump in this case, which I'd rather avoid.

[woodsb02]

Ok, I will not commit this. Will leave it to you :)

[woodsb02]

Hi danfe,
I have had a quick look, and you might be interested to know that the security/john port with the jumbo versioning is actually less than without it.
$ pkg version -t 1.8.0.j.1 1.8.0
<

This means that if you move the jumbo version to an option, there would be no need to bump PORTEPOCH.

With this in mind, perhaps I can commit this update now, and you can work on moving the jumbo build to an option at a later date?

[danfe]

I had just actually started working on it when your comment arrived. Good observation on version's order. It actually helps because I do not see -jumbo patch against vanilla 1.8.0, while earlier Alexander assured me that it would always be available (and this is in fact required for optionizing -jumbo).

However there are several things about proposed patch that look strange to me (e.g. it does not use tar:xz for some reason and, more importantly, does not want to build, unable to find OpenSSL, albeit it might be my local problem).

I'd like to try find my way through these issues first, if you don't mind, and reduce number of patches we have to move around.

[koobs]

@danfe I believe you can 'Commandeer' this revision if you intend to update/commit it.

@woodsb02 Anything else you need from us on this?

[woodsb02]

In D7955#172333, @koobs wrote:

@woodsb02 Anything else you need from us on this?

Nope - just re-opened the review when I noticed the revision with jumbo would be less than the revision without jumbo, and saw an opportunity to get the change committed without negatively impacting danfe (who has since replied with other concerns).

@danfe: happy to either close this or let you adopt this review.

[woodsb02]

security/john updated to 1.8.0 in commit r425958.