dhclient(8): Enable numbered user class ID option

[cem]

Summary

By adding it to the option priorities table.

PR: 184117
Submitted by: Tomek CEDRO <cederom at tlen.pl>

Test Plan

It compiles.

[jhb]

This doesn't fully fix the PR, per se. I wonder how hard it would be to check for any other missing options in this table that the existing code already handles.

Hmm, OpenBSD removed this table entirely it seems. Might be interesting to see if their change to do that is worth bringing in. Unfortunately this is only the link to the CVS change for tables.c and not all the related files:

http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/tables.c.diff?r1=1.8&r2=1.9&f=h

[jhb]

http://marc.info/?l=openbsd-cvs&m=112129754521096&w=2

is the full commit log

[jhb]

http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/options.c.diff?r1=1.18&r2=1.19&f=h

is what removes the use of this table though. (*sigh*)

[cem]

Github is a decent resource for OpenBSD history (multiple-file changes are grouped together nicely). Supposedly they rewrite history frequently, so I won't link to a specific sha1. Here's history for that file:

https://github.com/openbsd/src/commits/master/sbin/dhclient/tables.c

If you click a commit, such as the "Repair/rationalize option handling" one, you can see all changed files.

This doesn't fully fix the PR, per se. I wonder how hard it would be to check for any other missing options in this table that the existing code already handles.

Hmm, OpenBSD removed this table entirely it seems. Might be interesting to see if their change to do that is worth bringing in. Unfortunately this is only the link to the CVS change for tables.c and not all the related files:

I don't really have the dhclient expertise (or interest to acquire that expertise) needed to make bigger changes like that. But I'm happy to try and get trivial PRs like this landed.

Thanks for the review.