Page MenuHomeFreeBSD

Fix pidfile_test on MIPS
ClosedPublic

Authored by br on Sep 14 2016, 2:34 PM.

Details

Summary

switch to kqueue to ensure we will not loose SIGINT sent by parent to child

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

br retitled this revision from to Fix pidfile_test on MIPS.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added a reviewer: tests.

Hm, why's mips@ subscribed? this looks fine?

ngie added inline comments.
lib/libutil/tests/pidfile_test.c
172 ↗(On Diff #20344)

What was the exact error occurring here before? Did you ever trace that down?

Also, I wish that the return code from select(2) had been checked previously...

173 ↗(On Diff #20344)

Ensure kq != -1.

177 ↗(On Diff #20344)

Print out an error message with err or use a different exit code...?

183 ↗(On Diff #20344)

Print out an error message with err or use a different exit code...?

lib/libutil/tests/pidfile_test.c
172 ↗(On Diff #20344)

there is no error, but scheduler do a thread switch just after write(fd[1],...) and before select(), so child process miss signal and never dies (waits forever in select())

Please address my feedback.

lib/libutil/tests/pidfile_test.c
172 ↗(On Diff #20344)

Ok.

sbruno added a reviewer: sbruno.

I'm good with the current revision as the exit() values are now unique for the test.

This revision is now accepted and ready to land.Sep 19 2016, 4:07 PM
ngie edited edge metadata.

Please commit -- thank you!

This revision was automatically updated to reflect the committed changes.