Several small TCP related fixes for getsockopt()
ClosedPublic
Actions

Authored by tuexen on Sep 8 2016, 3:52 PM.

Details

Reviewers

hiren
rrs
jtl

Group Reviewers

transport

Summary

When using getsockopt(..., IPPROTO_TCP, TCP_INFO, ..., ...) the flag TCPI_OPT_ECN in tcpi_options is not set when ECN support has been successfully negotiated. This patch fixes this.

When using getsockopt(..., IPPROTO_TCP, TCP_KEEPINIT, ..., ...) a value of 0 is reported when the default value inherited from the sysctl variable net.inet.tcp.keepinit is used. This patch ensure that always the value used is reported.

When using getsockopt(..., IPPROTO_TCP, TCP_KEEPINTVL, ..., ...) a value of 0 is reported when the default value inherited from the sysctl variable net.inet.tcp.keepintvl is used. This patch ensure that always the value used is reported.

When using getsockopt(..., IPPROTO_TCP, TCP_KEEPIDLE, ..., ...) a value of 0 is reported when the default value inherited from the sysctl variable net.inet.tcp.keepidle is used. This patch ensure that always the value used is reported.

When using getsockopt(..., IPPROTO_TCP, TCP_KEEPCNT, ..., ...) a value of 0 is reported when the default value inherited from the sysctl variable net.inet.tcp.keepcnt is used. This patch ensure that always the value used is reported.

Test Plan

Using packetdrill test scripts to ensure that always the value actually used is reported. No matter if it is the default value or a value set by the user via a corresponding setsockopt() operation.